Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsconfig.json to core-data package #43638

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

adamziel
Copy link
Contributor

What?

This PR adds tsconfig.json to the @wordpress/core-data. It's a logical next step after adding all the useful TypeScript types.

Testing Instructions

Confirm the checks are green

cc @gziolo @dmsnell @sarayourfriend

@adamziel adamziel requested a review from nerrad as a code owner August 26, 2022 14:27
@adamziel adamziel self-assigned this Aug 26, 2022
@adamziel adamziel added [Type] Enhancement A suggestion for improvement. [Package] Core data /packages/core-data Developer Experience Ideas about improving block and theme developer experience labels Aug 26, 2022
@gziolo
Copy link
Member

gziolo commented Aug 26, 2022

I see that TypeScript validation passes on CI. Is there anything left to expose types for the package on npm?

@adamziel
Copy link
Contributor Author

adamziel commented Aug 26, 2022

I see that TypeScript validation passes on CI. Is there anything left to expose types for the package on npm?

I think so, yes 🎉 This PR gets all the remaining types to behave.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s your call then whether to expose types in this PR or separately 👍

When exposing types we only need to remember to include a breaking change entry in the changelog. We definitely will have different types than those that live now on DefinitelyTyped.

@adamziel adamziel merged commit 5d31bfa into trunk Aug 26, 2022
@adamziel adamziel deleted the ts/enable-tsconfig-json-in-core-data branch August 26, 2022 16:01
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Package] Core data /packages/core-data [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants