Cover Block: Keep the inner contents in a physical direction even in RTL languages #43663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
Internationalization (i18n)
|
Size Change: -70 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for working on this @t-hamano 👍
Unfortunately, it doesn't appear to be working for me, assuming I'm not doing something wrong following your test instructions.
The frontend doesn't maintain the physical direction selected within the editor. Here's an example of some of what I'm seeing.
Screen.Recording.2022-09-06.at.12.12.10.pm.mp4
|
@aaronrobertshaw
|
|
Or, CSS cache might be applied on the front-end. |
aaronrobertshaw
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Thanks for confirming the test instructions @t-hamano.
Or, CSS cache might be applied on the front end.
What wasn't in the video I recorded for my last comment was that I had dev tools open for each of the tabs and caching disabled.
After restarting my local environment and rebuilding Gutenberg, this is working for me. Apologies for the false alarm.
Click for long video of some re-testing
Screen.Recording.2022-09-07.at.11.30.31.am.mp4
Impact on Consumers
This change flips the position of the inner contents from left to right on sites where the RTL language is applied. Is this impact acceptable?
I'm not sure about what impact is acceptable and what isn't. At the least, I'd say we need to communicate this change. Perhaps @annezazu might be able to offer some insight around the best approach if we choose to proceed landing this change.
For the moment, I'll optimistically approve this PR.
|
Thank you for the re-test, @aaronrobertshaw! I would like to merge this change because I think it is reasonable. |
t-hamano
added
the
Needs Dev Note
|
@t-hamano Thanks to you its on our radar for the WordPress 6.1 release, and we'll add it to the Field Guide or a Misc Dev note together with other Block editor updates. Thanks for the great work on this PR! |
|
@bph The cover block now keeps the inner contents in its physical direction to prioritize its original function, regardless of the language orientation. |
|
This comment is a bit too short, for even a paragraph in a dev note that hasn't been written yet. @jorgefilipecosta @t-hamano are you working on an overall dev note to add this to? Or am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #43625
Follow-up on #43126
What?
This PR physically fixes the position of the content in the cover block, regardless of language direction.
Why?
See: #43625 (comment)
How?
I applied
direction: ltrto the cover block in the RTL language by usin thertl:rawcomment.However, the direction of the language should be taken into account in the inner content, so in
.wp-block-cover__inner-container,direction:rtlis applied only for RTL languages.At the same time, the quick fix done in #43126 was removed as it was no longer needed.
Testing Instructions
Screenshots or screencast
This is an example of setting the inner content to the bottom right.
Impact on Consumers
This change flips the position of the inner contents from left to right on sites where the RTL language is applied. Is this impact acceptable?