Fix display of width controls for legacy layouts #43688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +9 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Good catch @tellthemachines!
On trunk, I can replicate that the controls are displayed twice in the constrained layout when a contentSize is set, and they were not displaying for the Query block in the markup provided. Afterwards, this PR ensures the additional / legacy controls are only displayed when there is no layout type set, and the Query block with the provided markup now displays the controls 👍
| Before | After |
|---|---|
 |
 |
LGTM! ✨
andrewserong
added
[Type] Bug
andrewserong
added
the
[Feature] Layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes display of custom content/wide width controls for blocks that have legacy "inherit" and "contentSize" attributes.
Why?
How?
Testing Instructions
Try the following test markup:
and
Check that both the Query block and the first Column in the Columns block display the "content" and "wide" controls in the sidebar Layout section.
Also chech that the bug reported here is fixed:
Screenshots or screencast