Font size picker: add a fallback for the name property #43794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p control options. Before, if "name" was not defined the value was `undefined`
ramonjd
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Using the label as a fallback for "name" in the font size toggle group control options. Props to @jasmussen for spotting in #43074 (comment)
Why?
Before, if "name" was not defined the value was
undefined. Who would have thought?!It was only obvious on the fifth element since the name fields were inherited from the default theme.json.
How?
See "What". Also updated unit tests.
Testing Instructions
Where there are five font sizes or fewer, the
<ToggleGroupControl />displays with t-shirt sizes. Example JSON below.Check that the "name" property is filled for each
<ToggleGroupControlOption />(and, more importantly, the fifth font size XXL)I wasn't sure where the
namevalue manifested itself, so I was using React Developer Tools to inspect the component and check the props.Example theme.json
{ "version": 2, "settings": { "appearanceTools": true, "typography": { "fontSizes": [ { "fluid": { "min": "0.875rem", "max": "1rem" }, "size": "1rem", "slug": "small" }, { "fluid": { "min": "1rem", "max": "1.125rem" }, "size": "1.125rem", "slug": "medium" }, { "size": "1.75rem", "slug": "large", "fluid": false }, { "size": "2.25rem", "slug": "x-large", "fluid": false }, { "size": "10rem", "slug": "xx-large", "fluid": { "min": "4rem", "max": "12rem" } } ] } } }Before
After