Lodash: Refactor away from _.forEach()
#43807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
sgomes,
aristath,
gziolo,
swissspidy,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
tyxla
requested review from
ajitbohra,
ntwb,
nerrad,
ellatrix and
geriux
as code owners
|
Size Change: +84 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
tyxla
added
the
Mobile App - i.e. Android or iOS
tyxla
force-pushed
the
refactor/lodash-foreach
branch
from
6d95697 to
c875693
Compare
sgomes
approved these changes
Sep 2, 2022
| @@ -32,8 +27,8 @@ export function hideApp( unhiddenElement ) { | |||
| if ( isHidden ) { | |||
| return; | |||
| } | |||
| const elements = document.body.children; | |||
| forEach( elements, ( element ) => { | |||
| const elements = Array.from( document.body.children ); | |||
There was a problem hiding this comment.
TIL the collections returned by Element.prototype.children() don't have a forEach method...
There was a problem hiding this comment.
Yeah, HTMLCollection is limited to having .length, but doesn't reliably implement the iterator protocol in all browsers. Some browser support some means of iteration (like for/of and for/in for example) but not reliably, so Array.from() ensures we'll be able to iterate the collection of elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the
_.forEach()usage completely and deprecates the function.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're essentially replacing with
Array.prototype.forEach(), with a few specifics in mind:Object.entries()when we use both the object keys and values.Object.keys()when we use only the object keys.Object.values()when we use only the object values.The PR might look a little on the large side, but that's mostly because lots of the indentation needs to change after the minor changes, so most of it consists of whitespace changes.
Testing Instructions
@wordpress/babel-plugin-makepotworks, runnpm run test:unit packages/babel-plugin-makepot/test/index.jsand verify they still pass.withGlobalEventswork, verify its tests still pass:npm run test:unit packages/compose/src/higher-order/with-global-events/test/index.js@wordpress/dataregistry still works, verify these tests still pass:npm run test:unit packages/data/src/test/registry.jstrunkand ensure nothing has changed).npm run test:unit packages/edit-site/src/components/global-stylesnpm run test:unit packages/viewport