Block editor: Move margins to theme.scss and common.scss #43813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Regression
|
Size Change: +169 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 2, 2022
|
Can we come up with a more extensive list of edge cases that needs to be tested? |
I think the owl selector will still provide the spacing in the this circumstance. |
|
Tested with underscores ( |
andrewserong
approved these changes
Sep 6, 2022
| /** | ||
| * Reset user agent styles for figure element margins. | ||
| */ | ||
| figure { |
There was a problem hiding this comment.
If need be, we could always reduce the specificity of this one via :where(figure) if it has potential to conflict with themes' provided styles?
|
Ha! I was 5 minutes late to reviewing this one... ah well, better late than never 😆 |
|
Thanks @andrewserong |
9 tasks
|
The margin property is invalid for the table-block.... ;-) looks like a classic copy & paste mishap. packages/block-library/src/table/theme.scss All the best, |
|
Thanks for the heads-up @PaulSchiretz! I have a fix open here: #45674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an alternative to #43792
This moves margins from the block.json to theme.scss. This means the load order is preserved in the front and backend.
I have also added a reset to the common.scss file, so that if themes don't want to load opinionated styles they will still get this reset on the figure elements like image and embed.
I'd rather have the margins in theme.scss than style.scss because style.scss should ideally only contain rules that cannot be expressed in theme.json. We could probably get away with only having this rule in common.scss but the specificity will be different, so it's safer to also leave the existing rules in theme.scss as well.
Fixes #43618
Why?
So that the editor matches the frontend.
Testing Instructions