BlockInspector, ComplementaryArea: Fix overscoped p style
#43866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
Size Change: +65 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Sep 5, 2022
Yep, that also starts specificity battles with other overrides like this 😅 |
|
Thanks for fixing this, the toggle looks good again 🙏 I would echo Marco's comments that it'd be nice if there was a better solution. Would it be an option to leverage |
Exactly, that was one of the nicest options I considered! It's on our todo list to update the |
Proposed in #43995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an overscoped
pmargin-top style in the editor sidebar.Why?
A regression in the Drop cap control was reported.
How?
I considered a couple approaches where this would be addressed in the ToggleControl component itself, like replacing the
pwith adiv, or using a div wrapper and adding whitespace with VStack. However, these add extra complexity because we still need to maintain the legacy margin bottom behavior, and it can also easily break other style overrides.So in the end, I think the approach in this PR is probably the least bad.
Testing Instructions
First, change this
isDropCapFeatureEnabledvariable totrue:gutenberg/packages/block-library/src/paragraph/edit.js
Line 83 in 4e41498
npm run devScreenshots or screencast