AnglePickerControl: Deprecate margin bottom #43867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Package] Components
20 tasks
|
Size Change: +136 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Sep 5, 2022
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358
What?
Officially deprecates the bottom margin from AnglePickerControl.
Why?
Better reusability.
How?
Follows the style deprecation guide.
Testing Instructions
✅ All usages of AnglePickerControl in the repo should have a truthy
__nextHasNoMarginBottomprop.✍️ Dev Note
Components with deprecated margin styles
A number of UI components currently ship with styles that give them top and/or bottom margins. This can make it hard to reuse them in arbitrary layouts, where you want different amounts of gap or margin between components.
To better suit modern layout needs, we will gradually deprecate these outer margins. A deprecation will begin with an opt-in period where you can choose to apply the new margin-free styles on a given component instance. Eventually in a future version, the margins will be completely removed.
In WordPress 6.1, the outer margins on the following components have been deprecated.
AnglePickerControlFontSizePickerGradientPickerCustomGradientPickerTo start opting into the new margin-free styles, set the
__nextHasNoMarginBottomprop totrue.