Fix: Site logo rounded on mobile. #43903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +26 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Thanks, @jasmussen. The fix works as expected.
It looks like wrapper div logic has been there since the very beginning. @scruffian, do you remember why this is needed?
gutenberg/packages/block-library/src/site-logo/edit.js
Lines 157 to 159 in 4c7298d
Screenshots
| Before | After |
|---|---|
 |
 |
|
Thank you, I'll merge this, we can always follow up. This extra div from the CSS was probably erroneously refactored out as I cleaned things up recently. |
|
I'm wondering if we can remove extra div logic altogether in a follow-up. |
|
No, sorry it's been too long! |
|
No worries, @scruffian. Thanks for the reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #43762. Turns out on mobile, only in the editor, there's an additional wrapping div around the site logo, which needs inheritance. This PR adds that.
Before:
After:
Is there a way to e2e test this.
Testing Instructions
The site logo should remain round.