Editor: Refactor PostPublishPanel tests to @testing-library/react
#43908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: +1.92 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
The refactor in itself looks good! 🚀
although now that the snapshots are showing the actual rendered DOM, there may be a few issues that we'd like to address (see my inline comments). If we were to write these tests with more details assertions (i.e look for a button with a certain label, look for the post title's text etc), those assertions would currently fail. I suspect it's related to the need of mocking the data layer.
I understand that this PR focuses on refactoring to RTL, so feel free to merge it — but we should definitely make a note and iterated on these tests, because they currently offer very little value
packages/editor/src/components/post-publish-panel/test/__snapshots__/index.js.snap
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/test/__snapshots__/index.js.snap
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/test/__snapshots__/index.js.snap
Outdated
Show resolved
Hide resolved
cbravobernal
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/react.This PR refactors the
<PostPublishPanel />component tests fromenzymeto@testing-library/react.Why?
@testing-library/reactprovides a better way to write tests for accessible components that is closer to the way the user experiences them.Ideally, we should not be using snapshot tests here, however, the purpose of this PR is not to improve or enrich the tests themselves, but rather to migrate them
@testing-library/react. Our primary motivation is unblocking the upgrade to React 18.How?
We're straightforwardly replacing
enzymetests with@testing-library/reactones, usingjest-dommatchers and mocks to avoid testing unrelated implementation details.Testing Instructions
Verify tests pass:
npm run test:unit packages/editor/src/components/post-publish-panel/test/index.js