-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unstaged docs error message #43953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
A suggestion for improvement.
[Type] Build Tooling
Issues or PRs related to build tooling
labels
Sep 7, 2022
Mamaduka
requested review from
gziolo,
ryanwelcher and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
September 7, 2022 14:11
gziolo
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I anticipated it might come up one day 👍🏻
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it myself too, and I think the message makes sense 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Build Tooling
Issues or PRs related to build tooling
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates the error message for unstaged API docs to suggest
docs:build
instead ofdocs:blocks
.Why?
The
docs:blocks
will build only for blocks, whiledocs:build
runs a general build.Testing Instructions
Update doc block for data selector or actions. Try committing without regeneration docs, and confirm the correct message.