DropZone: Convert to TypeScript #43962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +60 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
mirka
commented
Sep 7, 2022
| @@ -149,7 +182,7 @@ export default function DropZoneComponent( { | |||
| } ); | |||
|
|
|||
| return ( | |||
| <div ref={ ref } className={ classes }> | |||
| <div { ...restProps } ref={ ref } className={ classes }> | |||
There was a problem hiding this comment.
| export default function DropZoneProvider( { | ||
| children, | ||
| }: { | ||
| children: React.ReactNode; |
There was a problem hiding this comment.
Not going to extract this to the types.ts file because this is deprecated.
Comment on lines
+36
to
+43
| * @param {Object} props Named parameters. | ||
| * @param {boolean} [props.isDisabled] Whether or not to disable the drop zone. | ||
| * @param {(e: DragEvent) => void} [props.onDragStart] Called when dragging has started. | ||
| * @param {(e: DragEvent) => void} [props.onDragEnter] Called when the zone is entered. | ||
| * @param {(e: DragEvent) => void} [props.onDragOver] Called when the zone is moved within. | ||
| * @param {(e: DragEvent) => void} [props.onDragLeave] Called when the zone is left. | ||
| * @param {(e: MouseEvent) => void} [props.onDragEnd] Called when dragging has ended. | ||
| * @param {(e: DragEvent) => void} [props.onDrop] Called when dropping in the zone. |
ciampo
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
LGTM 🚀
Just flagging some unexpected behavior from interacting with the component on Storybook (although I don't think that any of this was introduced by the changes from this PR):
Kapture.2022-09-09.at.19.35.18.mp4
- The blue overlay takes the whole canvas, instead of the area where the component renders initially
- The blue overlay doesn't always animate smoothly when opening
- The blue overlay doesn't always close when leaving the drop area with the pointer
| const [ isDraggingOverElement, setIsDraggingOverElement ] = useState(); | ||
| const [ type, setType ] = useState(); | ||
| ...restProps | ||
| }: WordPressComponentProps< DropZoneProps, 'div', false > ) { |
There was a problem hiding this comment.
Should this component be polymorphic?
There was a problem hiding this comment.
It could be potentially, but not in the current form because the div used in the code is a raw div element and not a polymorphic one (like View or styled.div).
Thanks, I'll file some issues once the Storybook is live 👍 |
cbravobernal
added
the
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
What?
Converts DropZone to TypeScript, and adds a story.
Why?
Better docs and devex.
Testing Instructions
npm run storybook:devand see stories for DropZone in Docs view.