Edit Post: Refactor PageAttributesOrder tests to @testing-library/react
#43980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
Mamaduka,
mirka,
ciampo,
chad1008 and
ntsekouras
|
Size Change: +142 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Sep 8, 2022
Mamaduka
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
This works well in my tests.
I will leave the final decision about #43980 (comment) to you, @ciampo and @mirka.
ciampo
reviewed
Sep 9, 2022
Comment on lines
+13
to
+20
| /** | ||
| * When starting to type inside the spinbutton, select the current value | ||
| * in order to override it with the new value afterwards. | ||
| */ | ||
| const typeOptions = { | ||
| initialSelectionStart: 0, | ||
| initialSelectionEnd: 1, | ||
| }; |
There was a problem hiding this comment.
I know I'm late, but wouldn't this only the first character in the input's value, instead of the whole value?
A good alternative could be to use the clear utility
There was a problem hiding this comment.
I did try .clear() but didn't like the end result, because it was adding additional invocations of the mocks, while this approach kept them the same as the original.
cbravobernal
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/react.This PR refactors the
<PageAttributesOrder />component tests fromenzymeto@testing-library/react.Why?
@testing-library/reactprovides a better way to write tests for accessible components that is closer to the way the user experiences them.How?
We're straightforwardly replacing
enzymetests with@testing-library/reactones, usingjest-dommatchers and mocks to avoid testing unrelated implementation details.Testing Instructions
Verify tests pass:
npm run test:unit packages/editor/src/components/page-attributes/test/order.js