Fix block transform preview height #44076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
It looks like this does fix some subtle block pattern preview issues too (the pagination items at the bottom were previously cut-off): Before
After
|
|
Size Change: +40 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
|
I am testing, but will attach a screencast later, as it appears to be affecting the |
|
I have confirmed that strange misalignments occur in the normal block inserter. On trunk
On this branch
This problem seems to be related to
It looks like |
|
Nice catch, @t-hamano 👍 |
|
Thanks for catching that @t-hamano! I've pushed your suggested fix. That does resolve the issue in my testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #43829
This is possibly a regression from #38516, though it may also be related to changes to
useResizeObserver. It's hard to say—it seems unusual that #38516 was merged quite a while ago, but this issue has only just been spotted.How?
#38516 added a
positionofrelativefor the iframe's body element to fix an issue with pattern previews. It did this because the react resize aware docs suggest to do this (https://github.com/FezVrasta/react-resize-aware#usage):I think the problem with
relativeis that the listener doesn't take margin into account since the margin collapses.Using a position like
absoluteseems to fix things since margin won't collapse in an absolute container (https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing). Changing toabsoluterequired setting awidth: 100%as otherwise blocks likecoverwouldn't take up full width.Testing Instructions
Expected: The heading block should be fully visible in the preview
Also test that this didn't regress block pattern previews as described in #38501, since this PR changes the fix for that issue.
Screenshots or screencast
Before
After