-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block switcher preview scrollbar #44079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
An existing feature does not function as intended
[Feature] Blocks
Overall functionality of blocks
labels
Sep 12, 2022
Size Change: +7 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. Thanks, @talldan!
This was referenced May 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Blocks
Overall functionality of blocks
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the scrollbar issue mentioned in #43829. A scrollbar shouldn't be visible on block previews.
How?
Sets
overflow: hidden
.I think this bug is related to changes to the popover component, where
overflow: auto
is set on popover content in some instances:gutenberg/packages/components/src/popover/index.tsx
Line 305 in c011452
The block switcher previews already have a max-height of 500px, so it seems sensible to set
overflow: hidden
as part of that, and it's a better idea for the component to handle that itself rather than relying on another component's implicit behavior.This also required changing from
padding
tomargin
, which seems correct anyway.Testing Instructions
Expected: The preview should not have a scrollbar.
Screenshots or screencast
Before
After