Migrate iframed block test to Playwright #44164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevin940726 @talldan I have submitted another PR. Can you please take a look at it and please review? |
kevin940726
reviewed
Sep 24, 2022
kevin940726
reviewed
Sep 25, 2022
|
@kevin940726 Thanks for your review! I have addressed your feedbacks. Can you please take a look at it? |
|
@kevin940726 Thanks 😊 Do i have to add anything to get Merging this PR? |
|
Nothing! I'm just waiting for the CI to pass 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrate iframed-block.test.js to its Playwright version.
Why?
See #38570 for its background and rationale.
How?
See MIGRATION.md for migration steps.
Testing Instructions
npm run test:e2e:playwright test/e2e/specs/editor/plugins/iframed-block.spec.jsScreencast
Screen.Recording.2022-09-14.at.11.45.56.PM.mov