Navigation: Fallback to a classic menu if one is available#44173

Merged

scruffian merged 33 commits intotrunkfrom update/navigation-classic

Oct 6, 2022

+181-34

Commits on Oct 4, 2022

Navigation: Fallback to a classic menu if one is availiable

scruffian
authored and
draganescu
committed
only use classic menus if there is one

scruffian
authored and
draganescu
committed
only import classic menus if there's only one of them

scruffian
authored and
draganescu
committed
fix gutenberg_convert_menu_items_to_blocks

scruffian
authored and
draganescu
committed
refactor

scruffian
authored and
draganescu
committed
only create navigation once, and create it published

scruffian
authored and
draganescu
committed
remove the code that makes the block dirty

scruffian
authored and
draganescu
committed
convert navigation with submenu items correctly

scruffian
authored and
draganescu
committed
php lint

scruffian
authored and
draganescu
committed
use a different function to convert classic menus to blocks

scruffian
authored and
draganescu
committed
add error handling

scruffian
authored and
draganescu
committed
Update packages/block-library/src/navigation/index.php

authored and
draganescu
committed
Update packages/block-library/src/navigation/index.php

authored and
draganescu
committed
Update packages/block-library/src/navigation/index.php

authored and
draganescu
committed
pass second param as true

scruffian
authored and
draganescu
committed
Use existing classic menu conversion state

getdave
authored and
draganescu
committed
Update packages/block-library/src/navigation/edit/index.js

authored and
draganescu
committed
rename function

scruffian
authored and
draganescu
committed
Fixes multiple menu creation on import. Also:

committed
return early when we won't continue

scruffian
authored and
draganescu
committed
a comment about where the duplicated code starts

scruffian
authored and
draganescu
committed
Update packages/block-library/src/navigation/index.php

authored and
draganescu
committed
Update packages/block-library/src/navigation/index.php

authored and
draganescu
committed
make the callback from the useEffect return a function not a promise

scruffian
authored and
draganescu
committed
remove await as this doesn't need to be async

scruffian
authored and
draganescu
committed

Commits on Oct 6, 2022

serialize blocks in the function that gets the classic menu
scruffian
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navigation: Fallback to a classic menu if one is available#44173

Commits on Oct 4, 2022

Navigation: Fallback to a classic menu if one is availiable

only use classic menus if there is one

only import classic menus if there's only one of them

fix gutenberg_convert_menu_items_to_blocks

refactor

only create navigation once, and create it published

remove the code that makes the block dirty

convert navigation with submenu items correctly

php lint

use a different function to convert classic menus to blocks

add error handling

Update packages/block-library/src/navigation/index.php

Update packages/block-library/src/navigation/index.php

Update packages/block-library/src/navigation/index.php

pass second param as true

Use existing classic menu conversion state

Update packages/block-library/src/navigation/edit/index.js

rename function

Fixes multiple menu creation on import. Also:

return early when we won't continue

a comment about where the duplicated code starts

Update packages/block-library/src/navigation/index.php

Update packages/block-library/src/navigation/index.php

make the callback from the useEffect return a function not a promise

remove await as this doesn't need to be async

Commits on Oct 5, 2022

Prevent classic menus from importing twice'

revert unnecessary changes

lint fix

Rename variable for clarity

Fix var rename

Reset the menu id on error

Revert testing code

Commits on Oct 6, 2022

serialize blocks in the function that gets the classic menu