Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate site-editor-inserter e2e test to Playwright #44507

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Migrate site-editor-inserter e2e test to Playwright #44507

merged 6 commits into from
Oct 25, 2022

Conversation

alvitazwar
Copy link
Contributor

@alvitazwar alvitazwar commented Sep 27, 2022 •
edited
Loading

What?

Based on #38570, part of #38851. Migrate site-editor-inserter.test.js to its Playwright counterpart.

Why?

See #38570 for its background and rationale.

This is split into a new PR for easier review.

##How?
See #38570 for the proposed migration steps.

##Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/site-editor/site-editor-inserter.spec.js

Screencast

Screen.Recording.2022-09-30.at.3.35.18.PM.mov

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 27, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @alvitazwar! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Sep 27, 2022
@alvitazwar
Copy link
Contributor Author

@kevin940726 can you please review this PR?

@alvitazwar
Copy link
Contributor Author

@Mamaduka Can you please help me to review this PR?

@alvitazwar
Copy link
Contributor Author

@kevin940726 please check now

@alvitazwar
Copy link
Contributor Author

Addressed locator feedback

@kevin940726 kevin940726 mentioned this pull request Oct 21, 2022
Closed
kevin940726
kevin940726 approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

test/e2e/specs/site-editor/site-editor-inserter.spec.js Show resolved Hide resolved
test/e2e/specs/site-editor/site-editor-inserter.spec.js Show resolved Hide resolved
@alvitazwar
Copy link
Contributor Author

Thanks @kevin940726 for the support

@kevin940726
Copy link
Member

There seems to have conflicts, do you mind rebasing? :)

@alvitazwar alvitazwar force-pushed the migrate/site-editor-inserter branch from 13f28dd to 0ecc8b3 Compare October 24, 2022 12:01
@alvitazwar alvitazwar force-pushed the migrate/site-editor-inserter branch from 0ecc8b3 to 95caf94 Compare October 24, 2022 12:08
@alvitazwar
Copy link
Contributor Author

@kevin940726 Please check now

kevin940726
kevin940726 reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to remove the original test and then we should be all set! Thanks!

kevin940726
kevin940726 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@kevin940726 kevin940726 changed the title Add site editor test case Migrate site-editor-inserter e2e test to Playwright Oct 25, 2022
@talldan
Copy link
Contributor

talldan commented Oct 25, 2022

The PHP test failures are unrelated (there's a fix in #45265), so I'll move ahead with merging this one.

@talldan talldan merged commit 3ed9aca into WordPress:trunk Oct 25, 2022
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 25, 2022
@ciampo ciampo mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
Gutenberg 14.5
Development

Successfully merging this pull request may close these issues.
4 participants
@alvitazwar @kevin940726 @talldan @Mamaduka