BorderBoxControl: Omit unit select when values are mixed #44592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes complete interface sense to me, as showing the unit would be misleading. 👍 👍 — probably just needs a code sanity check. Thank you! |
ciampo
added
[Type] Enhancement
ciampo
reviewed
Sep 30, 2022
There was a problem hiding this comment.
I believe this definitely goes in the right direction.
While testing in storybook, I noticed a few unexpected behaviors. In particular, if the 4 borders have same width but different color or style, when linking them the unit is still hidden, while the "quantity" is shown — to me that's a bit confusing
Kapture.2022-09-30.at.18.00.09.mp4
As a general rule, we should either:
- always show the "mixed" (i.e. unset) state when the 4 split borders are not exactly the same
- apply this logic separately for border width (quantity+unit), border color and border style
For example, in the scenario above, when switching from un-linked to linked, I would have expected to either see "1px" or "Mixed" (without unit).
Hope this makes sense! Happy to clarify otherwise
Good catch, thanks. It's a minor change to make the disabling of the unit select depend only on the border width being mixed. I think this gives us the best of both worlds. Here's a quick video of the component as of aeb352b Screen.Recording.2022-10-04.at.5.53.46.pm.mp4 |
ciampo
approved these changes
Oct 5, 2022
Thanks for the nudge; I'll add some tests tomorrow 👍 |
|
Size Change: +2.87 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
aaronrobertshaw
deleted the
update/border-box-control-omit-unit-select-when-mixed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Hides the unit select from the
BorderBoxControlwhen it has mixed values.Behind the scenes the control still maintains the most common unit selection from the mixed values. This way when the user adjusts the "linked" control then that previous unit selection is honoured.
Why?
How?
Adds a new
disableUnitsprop to theBorderControl, which is passed through to theUnitControl. When theBorderBoxControlhas mixed values it will use the new prop to disable the unit select.Alternative approach.
One alternative might be to simply check for the existence of a placeholder in the
BorderControl. At preset the only time this placeholder is set is when theBorderBoxControlpasses 'Mixed' to represent that state. This seemed a bit fragile and I can see in the near future if we gain access to Global Styles data in the post editor, that value might actually be used as a placeholder.Testing Instructions
Screenshots or screencast
Screen.Recording.2022-09-30.at.12.05.42.pm.mp4