[List v2]: Fix enter key action when the list is empty #44628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
t-hamano
changed the title
|
The issue this PR is trying to resolve has been resolved by #44864, so I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44627
This issue was found in WordPress Mega Meetup Japan 2022 Fall contribute event 🎉
What?
This PR fixes a problem where an unexpected paragraph block was generated when pressing the Enter key in an empty list.
Why?
If there are multiple list items and the Enter key is pressed in the middle of a list, the list is split and a paragraph block is generated between them. But in a list with one empty list item, the list itself should be converted into a paragraph block when the Enter key is pressed.
How?
When the Enter key is pressed, the list is now checked to see if it is "completely empty". If empty, it is converted to a paragraph block.
At the same time, I've added the E2e test.
Testing Instructions
Screenshots or screencast
Before
before.mp4
After
after.mp4