Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applyOrUnset() inconsistency. #4481

Merged
merged 1 commit into from
Jan 16, 2018
Merged

fix: applyOrUnset() inconsistency. #4481

merged 1 commit into from
Jan 16, 2018

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Jan 15, 2018

Description

See: #3859: Add consistency between AlignmentToolbar and BlockAlignment

Types of changes

Use an applyOrUnset() function to improve code clarity/consistency. These two components now match the approach taken by BlockAlignmentToolbar.

How Has This Been Tested?

Tested changes in Chrome to confirm that alignment continues to work as expected in each block, in the sidebar for each block, and that colors continue to toggle properly.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@jaswrks
Copy link
Contributor Author

jaswrks commented Jan 16, 2018

Ready for review.

@youknowriad youknowriad merged commit 8e87182 into WordPress:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants