Navigator: refactor Storybook code to TypeScript and controls #44979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
ciampo
force-pushed
the
refactor/navigatory-storybook-typescript
branch
from
39e623c to
d7b0103
Compare
ciampo
commented
Oct 14, 2022
| argTypes: { | ||
| as: { control: { type: null } }, | ||
| children: { control: { type: null } }, | ||
| initialPath: { control: { type: null } }, |
There was a problem hiding this comment.
I disabled the control for initialPath because changing it doesn't make any difference (it's only used on the component's first render)
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
ciampo
commented
Oct 14, 2022
| @@ -5,6 +5,7 @@ | |||
| ### Bug Fix | |||
|
|
|||
| - `FontSizePicker`: Ensure that fluid font size presets appear correctly in the UI controls ([#44791](https://github.com/WordPress/gutenberg/pull/44791)). | |||
| - `Navigator`: prevent partially hiding focus ring styles, by removing unnecessary overflow rules on `NavigatorScreen` ([#44973](https://github.com/WordPress/gutenberg/pull/44973)). | |||
There was a problem hiding this comment.
Adding a note for #44973 since it wasn't added in the original PR
aaronrobertshaw
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Nice work @ciampo 👍
All the changes and style tweaks make sense.
I didn't spot any unintended differences in Storybook between this PR and trunk. LGTM 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #35744
Refactor
Navigator's Storybook code to TypeScript and controls, thus enabling auto-generated documentation.Why?
Improving the code quality and the documentation of
@wordpress/components.How?
Navigatorsub-components are named/exported internally (as suggested in the migration guide)cxandcssfunctions, in favour or simpler inline styles (this is to show that Emotion is not necessary to consume and style our components)Reviewing this PR commit-by-commit may ease the reviewing process.
Testing Instructions
Interact with
Navigator's Storybook examples, make sure they look and work as ontrunk.