Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Try template drill down on shell sidebar (browse mode) #45100

Merged
merged 27 commits into from
Dec 9, 2022

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Oct 19, 2022

What?

This PR is a follow-up to #44770 that implements navigation for templates. The goal is to have something like this:

221018-site-editor-templates-drill-down.mp4

Why?

To explore how it looks like & find potential issues beforehand while controlling scope and implement one small thing at a time.

How?

It builds on #44770 and:

  • refactors the sidebar to implement in-place navigation for templates
  • loads templates individually in the frame

Testing Instructions

  • Open the side editor and navigate through templates.

Current state

For some reason, my cursor is not recorded:

Gravacao.de.ecra.a.partir.de.01-12-2022.13.24.40.webm

TODO:

  • Fix "edit" button for templates. It is misplaced.
  • Center align "Manage all templates".
  • Make sure the proper template is selected on first load (it loads index, but it is not highlighted).
  • Make templates scrollable. See.

In the interest of rapid iteration, we should probably not group templates in this PR, but in a follow-up.

@codesandbox
Copy link

codesandbox bot commented Oct 19, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@oandregal oandregal added the [Status] In Progress Tracking issues with work in progress label Oct 19, 2022
@oandregal oandregal self-assigned this Oct 19, 2022
@oandregal oandregal added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Oct 19, 2022
@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Size Change: -1.41 kB (0%)

Total Size: 1.32 MB

Filename Size Change
build/block-directory/style-rtl.css 1.04 kB +1 B (0%)
build/block-directory/style.css 1.04 kB +2 B (0%)
build/block-editor/content-rtl.css 2.71 kB +1 B (0%)
build/block-editor/default-editor-styles-rtl.css 403 B +2 B (0%)
build/block-editor/default-editor-styles.css 403 B +2 B (0%)
build/block-editor/index.min.js 181 kB +849 B (0%)
build/block-editor/style-rtl.css 14.6 kB +137 B (+1%)
build/block-editor/style.css 14.6 kB +138 B (+1%)
build/block-library/blocks/archives/editor-rtl.css 61 B -46 B (-43%) 🎉
build/block-library/blocks/archives/editor.css 60 B -46 B (-43%) 🎉
build/block-library/blocks/archives/style-rtl.css 90 B -39 B (-30%) 🎉
build/block-library/blocks/archives/style.css 90 B -39 B (-30%) 🎉
build/block-library/blocks/audio/editor-rtl.css 150 B -35 B (-19%) 👏
build/block-library/blocks/audio/editor.css 150 B -35 B (-19%) 👏
build/block-library/blocks/audio/style-rtl.css 122 B -36 B (-23%) 🎉
build/block-library/blocks/audio/style.css 122 B -36 B (-23%) 🎉
build/block-library/blocks/audio/theme-rtl.css 138 B -34 B (-20%) 🎉
build/block-library/blocks/audio/theme.css 138 B -34 B (-20%) 🎉
build/block-library/blocks/avatar/editor-rtl.css 116 B -38 B (-25%) 🎉
build/block-library/blocks/avatar/editor.css 116 B -38 B (-25%) 🎉
build/block-library/blocks/avatar/style-rtl.css 84 B -42 B (-33%) 🎉
build/block-library/blocks/avatar/style.css 84 B -42 B (-33%) 🎉
build/block-library/blocks/block/editor-rtl.css 305 B -33 B (-10%) 👏
build/block-library/blocks/block/editor.css 305 B -33 B (-10%) 👏
build/block-library/blocks/button/editor-rtl.css 485 B -32 B (-6%)
build/block-library/blocks/button/editor.css 485 B -32 B (-6%)
build/block-library/blocks/button/style-rtl.css 532 B -34 B (-6%)
build/block-library/blocks/button/style.css 532 B -34 B (-6%)
build/block-library/blocks/buttons/editor-rtl.css 337 B -36 B (-10%) 👏
build/block-library/blocks/buttons/editor.css 337 B -36 B (-10%) 👏
build/block-library/blocks/buttons/style-rtl.css 332 B -36 B (-10%) 👏
build/block-library/blocks/buttons/style.css 332 B -36 B (-10%) 👏
build/block-library/blocks/calendar/style-rtl.css 239 B -31 B (-11%) 👏
build/block-library/blocks/calendar/style.css 239 B -31 B (-11%) 👏
build/block-library/blocks/categories/editor-rtl.css 84 B -41 B (-33%) 🎉
build/block-library/blocks/categories/editor.css 83 B -41 B (-33%) 🎉
build/block-library/blocks/categories/style-rtl.css 100 B -38 B (-28%) 🎉
build/block-library/blocks/categories/style.css 100 B -38 B (-28%) 🎉
build/block-library/blocks/code/editor-rtl.css 53 B -49 B (-48%) 🎉
build/block-library/blocks/code/editor.css 53 B -49 B (-48%) 🎉
build/block-library/blocks/code/style-rtl.css 121 B -38 B (-24%) 🎉
build/block-library/blocks/code/style.css 121 B -38 B (-24%) 🎉
build/block-library/blocks/code/theme-rtl.css 124 B -36 B (-22%) 🎉
build/block-library/blocks/code/theme.css 124 B -36 B (-22%) 🎉
build/block-library/blocks/columns/editor-rtl.css 108 B -39 B (-27%) 🎉
build/block-library/blocks/columns/editor.css 108 B -39 B (-27%) 🎉
build/block-library/blocks/columns/style-rtl.css 406 B -36 B (-8%)
build/block-library/blocks/columns/style.css 406 B -36 B (-8%)
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125 B -38 B (-23%) 🎉
build/block-library/blocks/comment-author-avatar/editor.css 125 B -38 B (-23%) 🎉
build/block-library/blocks/comment-content/style-rtl.css 92 B -42 B (-31%) 🎉
build/block-library/blocks/comment-content/style.css 92 B -42 B (-31%) 🎉
build/block-library/blocks/comment-template/style-rtl.css 199 B -38 B (-16%) 👏
build/block-library/blocks/comment-template/style.css 198 B -38 B (-16%) 👏
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123 B -36 B (-23%) 🎉
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B -36 B (-23%) 🎉
build/block-library/blocks/comments-pagination/editor-rtl.css 222 B -36 B (-14%) 👏
build/block-library/blocks/comments-pagination/editor.css 209 B -40 B (-16%) 👏
build/block-library/blocks/comments-pagination/style-rtl.css 235 B -37 B (-14%) 👏
build/block-library/blocks/comments-pagination/style.css 231 B -37 B (-14%) 👏
build/block-library/blocks/comments-title/editor-rtl.css 75 B -43 B (-36%) 🎉
build/block-library/blocks/comments-title/editor.css 75 B -43 B (-36%) 🎉
build/block-library/blocks/comments/editor-rtl.css 840 B -35 B (-4%)
build/block-library/blocks/comments/editor.css 839 B -35 B (-4%)
build/block-library/blocks/comments/style-rtl.css 637 B -35 B (-5%)
build/block-library/blocks/comments/style.css 636 B -35 B (-5%)
build/block-library/blocks/cover/editor-rtl.css 612 B -34 B (-5%)
build/block-library/blocks/cover/editor.css 613 B -34 B (-5%)
build/block-library/blocks/cover/style-rtl.css 1.57 kB -36 B (-2%)
build/block-library/blocks/cover/style.css 1.56 kB -36 B (-2%)
build/block-library/blocks/embed/editor-rtl.css 293 B -34 B (-10%) 👏
build/block-library/blocks/embed/editor.css 293 B -34 B (-10%) 👏
build/block-library/blocks/embed/style-rtl.css 410 B -36 B (-8%)
build/block-library/blocks/embed/style.css 410 B -36 B (-8%)
build/block-library/blocks/embed/theme-rtl.css 138 B -34 B (-20%) 🎉
build/block-library/blocks/embed/theme.css 138 B -34 B (-20%) 🎉
build/block-library/blocks/file/editor-rtl.css 300 B -35 B (-10%) 👏
build/block-library/blocks/file/editor.css 300 B -35 B (-10%) 👏
build/block-library/blocks/file/style-rtl.css 253 B -35 B (-12%) 👏
build/block-library/blocks/file/style.css 254 B -34 B (-12%) 👏
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB -30 B (-1%)
build/block-library/blocks/freeform/editor.css 2.44 kB -29 B (-1%)
build/block-library/blocks/gallery/editor-rtl.css 984 B -3 B (0%)
build/block-library/blocks/gallery/editor.css 988 B -5 B (-1%)
build/block-library/blocks/gallery/style-rtl.css 1.55 kB -34 B (-2%)
build/block-library/blocks/gallery/style.css 1.55 kB -33 B (-2%)
build/block-library/blocks/gallery/theme-rtl.css 122 B -35 B (-22%) 🎉
build/block-library/blocks/gallery/theme.css 122 B -35 B (-22%) 🎉
build/block-library/blocks/group/editor-rtl.css 654 B -33 B (-5%)
build/block-library/blocks/group/editor.css 654 B -33 B (-5%)
build/block-library/blocks/group/style-rtl.css 57 B -48 B (-46%) 🎉
build/block-library/blocks/group/style.css 57 B -48 B (-46%) 🎉
build/block-library/blocks/group/theme-rtl.css 78 B -47 B (-38%) 🎉
build/block-library/blocks/group/theme.css 78 B -47 B (-38%) 🎉
build/block-library/blocks/heading/style-rtl.css 76 B -52 B (-41%) 🎉
build/block-library/blocks/heading/style.css 76 B -52 B (-41%) 🎉
build/block-library/blocks/html/editor-rtl.css 332 B -33 B (-9%)
build/block-library/blocks/html/editor.css 333 B -33 B (-9%)
build/block-library/blocks/image/editor-rtl.css 829 B -32 B (-4%)
build/block-library/blocks/image/editor.css 828 B -31 B (-4%)
build/block-library/blocks/image/style-rtl.css 627 B -35 B (-5%)
build/block-library/blocks/image/style.css 630 B -36 B (-5%)
build/block-library/blocks/image/theme-rtl.css 137 B -35 B (-20%) 🎉
build/block-library/blocks/image/theme.css 137 B -35 B (-20%) 🎉
build/block-library/blocks/latest-comments/style-rtl.css 298 B -35 B (-11%) 👏
build/block-library/blocks/latest-comments/style.css 298 B -35 B (-11%) 👏
build/block-library/blocks/latest-posts/editor-rtl.css 213 B -37 B (-15%) 👏
build/block-library/blocks/latest-posts/editor.css 212 B -37 B (-15%) 👏
build/block-library/blocks/latest-posts/style-rtl.css 478 B -36 B (-7%)
build/block-library/blocks/latest-posts/style.css 478 B -36 B (-7%)
build/block-library/blocks/list/style-rtl.css 88 B -47 B (-35%) 🎉
build/block-library/blocks/list/style.css 88 B -47 B (-35%) 🎉
build/block-library/blocks/media-text/editor-rtl.css 266 B -34 B (-11%) 👏
build/block-library/blocks/media-text/editor.css 263 B -35 B (-12%) 👏
build/block-library/blocks/media-text/style-rtl.css 507 B -33 B (-6%)
build/block-library/blocks/media-text/style.css 505 B -34 B (-6%)
build/block-library/blocks/more/editor-rtl.css 431 B -34 B (-7%)
build/block-library/blocks/more/editor.css 431 B -34 B (-7%)
build/block-library/blocks/navigation-link/editor-rtl.css 716 B -30 B (-4%)
build/block-library/blocks/navigation-link/editor.css 715 B -29 B (-4%)
build/block-library/blocks/navigation-link/style-rtl.css 115 B -38 B (-25%) 🎉
build/block-library/blocks/navigation-link/style.css 115 B -38 B (-25%) 🎉
build/block-library/blocks/navigation-submenu/editor-rtl.css 299 B -34 B (-10%) 👏
build/block-library/blocks/navigation-submenu/editor.css 299 B -34 B (-10%) 👏
build/block-library/blocks/navigation/editor-rtl.css 2.15 kB -32 B (-1%)
build/block-library/blocks/navigation/editor.css 2.16 kB -33 B (-2%)
build/block-library/blocks/navigation/style-rtl.css 2.23 kB -36 B (-2%)
build/block-library/blocks/navigation/style.css 2.21 kB -36 B (-2%)
build/block-library/blocks/nextpage/editor-rtl.css 395 B -33 B (-8%)
build/block-library/blocks/nextpage/editor.css 395 B -33 B (-8%)
build/block-library/blocks/page-list/editor-rtl.css 363 B -34 B (-9%)
build/block-library/blocks/page-list/editor.css 363 B -35 B (-9%)
build/block-library/blocks/page-list/style-rtl.css 175 B -37 B (-17%) 👏
build/block-library/blocks/page-list/style.css 175 B -37 B (-17%) 👏
build/block-library/blocks/paragraph/editor-rtl.css 174 B -40 B (-19%) 👏
build/block-library/blocks/paragraph/editor.css 174 B -40 B (-19%) 👏
build/block-library/blocks/paragraph/style-rtl.css 279 B -42 B (-13%) 👏
build/block-library/blocks/paragraph/style.css 281 B -40 B (-12%) 👏
build/block-library/blocks/post-author/style-rtl.css 175 B -37 B (-17%) 👏
build/block-library/blocks/post-author/style.css 176 B -36 B (-17%) 👏
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B -41 B (-30%) 🎉
build/block-library/blocks/post-comments-form/editor.css 96 B -41 B (-30%) 🎉
build/block-library/blocks/post-comments-form/style-rtl.css 501 B -35 B (-7%)
build/block-library/blocks/post-comments-form/style.css 501 B -36 B (-7%)
build/block-library/blocks/post-date/style-rtl.css 61 B -46 B (-43%) 🎉
build/block-library/blocks/post-date/style.css 61 B -46 B (-43%) 🎉
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B -46 B (-39%) 🎉
build/block-library/blocks/post-excerpt/editor.css 73 B -46 B (-39%) 🎉
build/block-library/blocks/post-excerpt/style-rtl.css 69 B -47 B (-41%) 🎉
build/block-library/blocks/post-excerpt/style.css 69 B -47 B (-41%) 🎉
build/block-library/blocks/post-featured-image/editor-rtl.css 586 B -34 B (-5%)
build/block-library/blocks/post-featured-image/editor.css 584 B -34 B (-6%)
build/block-library/blocks/post-featured-image/style-rtl.css 318 B -31 B (-9%)
build/block-library/blocks/post-featured-image/style.css 318 B -31 B (-9%)
build/block-library/blocks/post-navigation-link/style-rtl.css 153 B -37 B (-19%) 👏
build/block-library/blocks/post-navigation-link/style.css 153 B -36 B (-19%) 👏
build/block-library/blocks/post-template/editor-rtl.css 99 B -41 B (-29%) 🎉
build/block-library/blocks/post-template/editor.css 98 B -41 B (-29%) 🎉
build/block-library/blocks/post-template/style-rtl.css 282 B -35 B (-11%) 👏
build/block-library/blocks/post-template/style.css 282 B -35 B (-11%) 👏
build/block-library/blocks/post-terms/style-rtl.css 96 B -40 B (-29%) 🎉
build/block-library/blocks/post-terms/style.css 96 B -40 B (-29%) 🎉
build/block-library/blocks/post-title/style-rtl.css 100 B -38 B (-28%) 🎉
build/block-library/blocks/post-title/style.css 100 B -38 B (-28%) 🎉
build/block-library/blocks/preformatted/style-rtl.css 103 B -36 B (-26%) 🎉
build/block-library/blocks/preformatted/style.css 103 B -36 B (-26%) 🎉
build/block-library/blocks/pullquote/editor-rtl.css 135 B -35 B (-21%) 🎉
build/block-library/blocks/pullquote/editor.css 135 B -35 B (-21%) 🎉
build/block-library/blocks/pullquote/style-rtl.css 326 B -31 B (-9%)
build/block-library/blocks/pullquote/style.css 325 B -32 B (-9%)
build/block-library/blocks/pullquote/theme-rtl.css 167 B -34 B (-17%) 👏
build/block-library/blocks/pullquote/theme.css 167 B -34 B (-17%) 👏
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B -36 B (-23%) 🎉
build/block-library/blocks/query-pagination-numbers/editor.css 121 B -35 B (-22%) 🎉
build/block-library/blocks/query-pagination/editor-rtl.css 221 B -37 B (-14%) 👏
build/block-library/blocks/query-pagination/editor.css 211 B -36 B (-15%) 👏
build/block-library/blocks/query-pagination/style-rtl.css 288 B -38 B (-12%) 👏
build/block-library/blocks/query-pagination/style.css 284 B -38 B (-12%) 👏
build/block-library/blocks/query-title/style-rtl.css 63 B -45 B (-42%) 🎉
build/block-library/blocks/query-title/style.css 63 B -45 B (-42%) 🎉
build/block-library/blocks/query/editor-rtl.css 440 B -35 B (-7%)
build/block-library/blocks/query/editor.css 440 B -37 B (-8%)
build/block-library/blocks/quote/style-rtl.css 213 B -40 B (-16%) 👏
build/block-library/blocks/quote/style.css 213 B -40 B (-16%) 👏
build/block-library/blocks/quote/theme-rtl.css 223 B -32 B (-13%) 👏
build/block-library/blocks/quote/theme.css 226 B -33 B (-13%) 👏
build/block-library/blocks/read-more/style-rtl.css 132 B -36 B (-21%) 🎉
build/block-library/blocks/read-more/style.css 132 B -36 B (-21%) 🎉
build/block-library/blocks/rss/editor-rtl.css 202 B -37 B (-15%) 👏
build/block-library/blocks/rss/editor.css 204 B -36 B (-15%) 👏
build/block-library/blocks/rss/style-rtl.css 289 B -34 B (-11%) 👏
build/block-library/blocks/rss/style.css 288 B -35 B (-11%) 👏
build/block-library/blocks/search/editor-rtl.css 165 B -40 B (-20%) 🎉
build/block-library/blocks/search/editor.css 165 B -40 B (-20%) 🎉
build/block-library/blocks/search/style-rtl.css 409 B -32 B (-7%)
build/block-library/blocks/search/style.css 406 B -33 B (-8%)
build/block-library/blocks/search/theme-rtl.css 114 B -35 B (-23%) 🎉
build/block-library/blocks/search/theme.css 114 B -35 B (-23%) 🎉
build/block-library/blocks/separator/editor-rtl.css 146 B -38 B (-21%) 🎉
build/block-library/blocks/separator/editor.css 146 B -38 B (-21%) 🎉
build/block-library/blocks/separator/style-rtl.css 234 B -35 B (-13%) 👏
build/block-library/blocks/separator/style.css 234 B -35 B (-13%) 👏
build/block-library/blocks/separator/theme-rtl.css 194 B -35 B (-15%) 👏
build/block-library/blocks/separator/theme.css 194 B -35 B (-15%) 👏
build/block-library/blocks/shortcode/editor-rtl.css 474 B -34 B (-7%)
build/block-library/blocks/shortcode/editor.css 474 B -34 B (-7%)
build/block-library/blocks/site-logo/editor-rtl.css 490 B -32 B (-6%)
build/block-library/blocks/site-logo/editor.css 490 B -32 B (-6%)
build/block-library/blocks/site-logo/style-rtl.css 203 B -35 B (-15%) 👏
build/block-library/blocks/site-logo/style.css 203 B -35 B (-15%) 👏
build/block-library/blocks/site-tagline/editor-rtl.css 86 B -43 B (-33%) 🎉
build/block-library/blocks/site-tagline/editor.css 86 B -43 B (-33%) 🎉
build/block-library/blocks/site-title/editor-rtl.css 116 B -39 B (-25%) 🎉
build/block-library/blocks/site-title/editor.css 116 B -39 B (-25%) 🎉
build/block-library/blocks/site-title/style-rtl.css 57 B -44 B (-44%) 🎉
build/block-library/blocks/site-title/style.css 57 B -44 B (-44%) 🎉
build/block-library/blocks/social-link/editor-rtl.css 184 B -35 B (-16%) 👏
build/block-library/blocks/social-link/editor.css 184 B -35 B (-16%) 👏
build/block-library/blocks/social-links/editor-rtl.css 674 B -35 B (-5%)
build/block-library/blocks/social-links/editor.css 673 B -35 B (-5%)
build/block-library/blocks/social-links/style-rtl.css 1.4 kB -36 B (-3%)
build/block-library/blocks/social-links/style.css 1.39 kB -36 B (-3%)
build/block-library/blocks/spacer/editor-rtl.css 332 B -40 B (-11%) 👏
build/block-library/blocks/spacer/editor.css 332 B -40 B (-11%) 👏
build/block-library/blocks/spacer/style-rtl.css 48 B -48 B (-50%) 🏆
build/block-library/blocks/spacer/style.css 48 B -48 B (-50%) 🏆
build/block-library/blocks/table/editor-rtl.css 457 B -34 B (-7%)
build/block-library/blocks/table/editor.css 457 B -34 B (-7%)
build/block-library/blocks/table/style-rtl.css 636 B -34 B (-5%)
build/block-library/blocks/table/style.css 635 B -34 B (-5%)
build/block-library/blocks/table/theme-rtl.css 184 B -36 B (-16%) 👏
build/block-library/blocks/table/theme.css 184 B -36 B (-16%) 👏
build/block-library/blocks/tag-cloud/style-rtl.css 251 B -36 B (-13%) 👏
build/block-library/blocks/tag-cloud/style.css 253 B -35 B (-12%) 👏
build/block-library/blocks/template-part/editor-rtl.css 403 B -33 B (-8%)
build/block-library/blocks/template-part/editor.css 403 B -33 B (-8%)
build/block-library/blocks/template-part/theme-rtl.css 101 B -38 B (-27%) 🎉
build/block-library/blocks/template-part/theme.css 101 B -38 B (-27%) 🎉
build/block-library/blocks/text-columns/editor-rtl.css 95 B -40 B (-30%) 🎉
build/block-library/blocks/text-columns/editor.css 95 B -40 B (-30%) 🎉
build/block-library/blocks/text-columns/style-rtl.css 166 B -32 B (-16%) 👏
build/block-library/blocks/text-columns/style.css 166 B -32 B (-16%) 👏
build/block-library/blocks/verse/style-rtl.css 87 B -43 B (-33%) 🎉
build/block-library/blocks/verse/style.css 87 B -43 B (-33%) 🎉
build/block-library/blocks/video/editor-rtl.css 691 B -29 B (-4%)
build/block-library/blocks/video/editor.css 694 B -29 B (-4%)
build/block-library/blocks/video/style-rtl.css 179 B -39 B (-18%) 👏
build/block-library/blocks/video/style.css 179 B -39 B (-18%) 👏
build/block-library/blocks/video/theme-rtl.css 139 B -32 B (-19%) 👏
build/block-library/blocks/video/theme.css 139 B -32 B (-19%) 👏
build/block-library/classic-rtl.css 162 B -31 B (-16%) 👏
build/block-library/classic.css 162 B -31 B (-16%) 👏
build/block-library/editor-elements-rtl.css 75 B -51 B (-40%) 🎉
build/block-library/editor-elements.css 75 B -51 B (-40%) 🎉
build/block-library/editor-rtl.css 11.7 kB +1 B (0%)
build/block-library/elements-rtl.css 54 B -51 B (-49%) 🎉
build/block-library/elements.css 54 B -51 B (-49%) 🎉
build/block-library/index.min.js 196 kB +271 B (0%)
build/block-library/reset-rtl.css 478 B -36 B (-7%)
build/block-library/reset.css 478 B -36 B (-7%)
build/block-library/style-rtl.css 12.4 kB -35 B (0%)
build/block-library/style.css 12.4 kB -36 B (0%)
build/block-library/theme-rtl.css 716 B -33 B (-4%)
build/block-library/theme.css 721 B -32 B (-4%)
build/blocks/index.min.js 50.4 kB +359 B (+1%)
build/components/index.min.js 204 kB +383 B (0%)
build/components/style-rtl.css 11.7 kB +95 B (+1%)
build/components/style.css 11.7 kB +96 B (+1%)
build/core-data/index.min.js 15.9 kB +296 B (+2%)
build/customize-widgets/index.min.js 11.6 kB +329 B (+3%)
build/customize-widgets/style-rtl.css 1.41 kB +1 B (0%)
build/data/index.min.js 8.14 kB +27 B (0%)
build/edit-navigation/style-rtl.css 4.14 kB +55 B (+1%)
build/edit-navigation/style.css 4.15 kB +61 B (+1%)
build/edit-post/classic-rtl.css 571 B +2 B (0%)
build/edit-post/classic.css 571 B +1 B (0%)
build/edit-post/index.min.js 34.5 kB +11 B (0%)
build/edit-post/style-rtl.css 7.49 kB +53 B (+1%)
build/edit-post/style.css 7.48 kB +53 B (+1%)
build/edit-site/index.min.js 63.3 kB +2.89 kB (+5%) 🔍
build/edit-site/style-rtl.css 9.02 kB +466 B (+5%) 🔍
build/edit-site/style.css 9.01 kB +463 B (+5%) 🔍
build/edit-widgets/style-rtl.css 4.48 kB +46 B (+1%)
build/edit-widgets/style.css 4.49 kB +47 B (+1%)
build/editor/index.min.js 44.1 kB +76 B (0%)
build/editor/style-rtl.css 3.69 kB +37 B (+1%)
build/editor/style.css 3.68 kB +36 B (+1%)
build/format-library/index.min.js 7.2 kB +232 B (+3%)
build/format-library/style-rtl.css 598 B +2 B (0%)
build/format-library/style.css 597 B +1 B (0%)
build/list-reusable-blocks/style-rtl.css 865 B +7 B (+1%)
build/list-reusable-blocks/style.css 865 B +8 B (+1%)
build/nux/style-rtl.css 775 B +3 B (0%)
build/nux/style.css 771 B +3 B (0%)
build/reusable-blocks/index.min.js 2.26 kB +33 B (+1%)
build/reusable-blocks/style-rtl.css 283 B +2 B (+1%)
build/reusable-blocks/style.css 283 B +2 B (+1%)
build/rich-text/index.min.js 10.7 kB +48 B (0%)
build/server-side-render/index.min.js 2.09 kB +313 B (+18%) ⚠️
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 993 B
build/annotations/index.min.js 2.78 kB
build/api-fetch/index.min.js 2.27 kB
build/autop/index.min.js 2.15 kB
build/blob/index.min.js 487 B
build/block-directory/index.min.js 7.16 kB
build/block-editor/content.css 2.71 kB
build/block-library/blocks/file/view.min.js 353 B
build/block-library/blocks/navigation/view-modal.min.js 2.81 kB
build/block-library/blocks/navigation/view.min.js 447 B
build/block-library/common-rtl.css 1.05 kB
build/block-library/common.css 1.05 kB
build/block-library/editor.css 11.7 kB
build/block-serialization-default-parser/index.min.js 1.13 kB
build/block-serialization-spec-parser/index.min.js 2.83 kB
build/compose/index.min.js 12.3 kB
build/customize-widgets/style.css 1.41 kB
build/data-controls/index.min.js 663 B
build/date/index.min.js 32.1 kB
build/deprecated/index.min.js 518 B
build/dom-ready/index.min.js 336 B
build/dom/index.min.js 4.74 kB
build/edit-navigation/index.min.js 16.2 kB
build/edit-widgets/index.min.js 16.7 kB
build/element/index.min.js 4.72 kB
build/escape-html/index.min.js 548 B
build/experiments/index.min.js 882 B
build/hooks/index.min.js 1.66 kB
build/html-entities/index.min.js 454 B
build/i18n/index.min.js 3.79 kB
build/is-shallow-equal/index.min.js 535 B
build/keyboard-shortcuts/index.min.js 1.79 kB
build/keycodes/index.min.js 1.86 kB
build/list-reusable-blocks/index.min.js 2.13 kB
build/media-utils/index.min.js 2.94 kB
build/notices/index.min.js 977 B
build/nux/index.min.js 2.07 kB
build/plugins/index.min.js 1.95 kB
build/preferences-persistence/index.min.js 2.23 kB
build/preferences/index.min.js 1.35 kB
build/primitives/index.min.js 960 B
build/priority-queue/index.min.js 1.59 kB
build/react-i18n/index.min.js 702 B
build/react-refresh-entry/index.min.js 8.44 kB
build/react-refresh-runtime/index.min.js 7.31 kB
build/redux-routine/index.min.js 2.75 kB
build/shortcode/index.min.js 1.52 kB
build/style-engine/index.min.js 1.51 kB
build/token-list/index.min.js 650 B
build/url/index.min.js 3.7 kB
build/vendors/inert-polyfill.min.js 2.48 kB
build/vendors/react-dom.min.js 41.8 kB
build/vendors/react.min.js 4.02 kB
build/viewport/index.min.js 1.09 kB
build/warning/index.min.js 280 B
build/widgets/index.min.js 7.23 kB
build/widgets/style-rtl.css 1.21 kB
build/widgets/style.css 1.21 kB
build/wordcount/index.min.js 1.06 kB

compressed-size-action

@jameskoster
Copy link
Contributor

jameskoster commented Oct 19, 2022

in the templates screen, select an individual template and then go back to design. Which section should be selected? Browse or Templates?

I think the important heuristic to install here is that the active menu item reflects what is visible in the site frame. So there are two options in regards to what happens when you click '< Design':

  1. The template that is visible in the site frame remains active in the navigation as well. (IE neither Browse nor Templates is active).
  2. Browse becomes active and the site frame is updated to display the site homepage.

I don't have a strong preference on either, so perhaps we can try whichever is simplest first? Definitely keen to hear thoughts from others. I think option 2 is likely the way to go :)

@jameskoster
Copy link
Contributor

jameskoster commented Oct 19, 2022

Some additional notes:

  • Clicking a template in the list view takes you directly the edit view for that template, could we try that in the side panel as well?
  • While editing a template, clicking the W button should open the side panel to the Templates section. This would effectively close Add a shortcut for template browsing #37001. Not entirely sure about this now, we can probably explore separately.
  • Probably something to do separately, but it would be good to offer template search/creation via the sidepanel:

Screenshot 2022-10-19 at 12 08 58

@oandregal
Copy link
Member Author

I'm pausing work on this until the base branch this depends on settles a bit. It's more dynamic than I thought when prepared this PR.

@youknowriad youknowriad force-pushed the try/admin-navigation branch 4 times, most recently from d574492 to c0aba96 Compare November 1, 2022 07:01
@annezazu annezazu mentioned this pull request Nov 1, 2022
57 tasks
@youknowriad youknowriad force-pushed the try/admin-navigation branch 2 times, most recently from ab23bb7 to 569315c Compare November 7, 2022 10:58
@youknowriad youknowriad force-pushed the try/admin-navigation branch 5 times, most recently from 64871fa to afd0bd0 Compare November 17, 2022 14:10
@youknowriad youknowriad force-pushed the try/admin-navigation branch 2 times, most recently from 949ad26 to a94be4c Compare November 30, 2022 08:41
@youknowriad
Copy link
Contributor

Good catch the jump appeared when we changed the focus style to 1.5 border, it's now fixed.

@ellatrix
Copy link
Member

ellatrix commented Dec 9, 2022

I'm also wondering if we can make switching between templates flash the screen less. Would be cool if we could wait for the template to load, then fade it in or something. Anyway, nit picking here.

@ellatrix
Copy link
Member

ellatrix commented Dec 9, 2022

I also have the feeling that we are re-rendering the whole iframe when switching templates. It doesn't feel smooth.

Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, let's merge and iterate.

@youknowriad
Copy link
Contributor

youknowriad commented Dec 9, 2022

I'm also wondering if we can make switching between templates flash the screen less. Would be cool if we could wait for the template to load, then fade it in or something. Anyway, nit picking here.

that's a good point, it's not really clear how to implement that, I think this maybe the purpose of useTransition in React 18, we'll have to experiment a bit with these APIs once we enable createRoot

@ellatrix
Copy link
Member

ellatrix commented Dec 9, 2022

One final nit pick... 😄

When I edit a template, and go back to browse, all my context is lost:

context-lost

@youknowriad
Copy link
Contributor

@ellatrix yes

see #45100 (comment) and #45100 (comment)

@jasmussen
Copy link
Contributor

Thanks for your work on this!

@youknowriad youknowriad enabled auto-merge (squash) December 9, 2022 09:32
@youknowriad youknowriad merged commit 299b85e into trunk Dec 9, 2022
@youknowriad youknowriad deleted the try/template-drill-down branch December 9, 2022 09:32
@github-actions github-actions bot added this to the Gutenberg 14.8 milestone Dec 9, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 13, 2022
@ryanwelcher ryanwelcher added the [Package] Edit Site /packages/edit-site label Dec 14, 2022
@ryanwelcher ryanwelcher changed the title Try template drill down on shell sidebar (browse mode) Site Editor: Try template drill down on shell sidebar (browse mode) Dec 14, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs User Documentation Needs new user documentation [Package] Edit Site /packages/edit-site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants