Tests: Use container instead of container.firstChild for snapshots
#45278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 25, 2022
Great question! I gave this a bit of thought before filing the PR - basically, because in the rule docs we can specifically read:
And I believe that it's actually pretty easy to avoid - having the wrapper as part of the snapshot doesn't hurt at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates snapshot tests that use RTL's
container.firstChildto usecontainerinstead. This changes the snapshots by adding the wrapper as well.Why?
Because it allows us to get rid of a bunch of
no-node-accessESLint violations for a very cheap price.Also, it's better according to Kent C. Dodds, if we don't compare snapshots before and after, see https://twitter.com/kentcdodds/status/1272186092779761669
How?
We're just replacing
container.firstChildwithcontainerand updating the tests.Testing Instructions
Verify all tests still pass.