Migrate Core settings test case #45320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mamaduka @kevin940726 can you Please review this PR? |
Mamaduka
added
the
[Type] Automated Testing
|
Hi! As per the best practices guideline, it's recommended to use role selectors instead. There are guides linked in the section, or you can visit the doc of testing-library for more info. Most browsers' devtools support inspecting the elements' accessible attributes, try searching for the relevant guides online ;) |
|
Closing this PR as It got some conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Based on #38570, part of #38851. Migrate core-settings.test.js
Why?
See #38570 for its background and rationale.
This is split into a new PR for easier review.
How?
See #38570 for the proposed migration steps.
Testing Instructions
npm run test:e2e:playwright /test/e2e/specs/editor/various/core-settings-test.spec.js
Screenshots or screencast
Screen.Recording.2022-10-26.at.6.40.19.PM.mov