Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover block: Add integration tests #45409
Cover block: Add integration tests #45409
Changes from 37 commits
042428d
fa0a316
2e41650
4fdb78b
214c315
5654827
019d5a3
80316b6
6360966
69b066e
249f9b1
2aa6d55
fd77c1f
0117b24
3043e47
65bfc75
43d855d
15ac92a
8af2060
d56dc26
fbc56c4
408e22e
21f97c7
4697a69
6f19aef
29bf6ba
19552d1
7bf0bce
a2f16fa
431b2ba
a293716
f201a3b
50a264a
a58601f
7a2b353
b0f0746
8948961
c5fccc6
93148ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still have class name selectors here (and a couple more below), do we also want to change these as well? Or is it a different case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the ones that related to the
img
but the remaining ones are just a span - I can't see another way of getting these other than adding adata-testid
or something, so maybe we should leave them as is until there is a resolution to that question about whether they should be stripped from production code.