Layout: Remove duplicate output of existing classnames in layout classnames #45499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
|
|
Size Change: -1 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks for fixing this @andrewserong ! Code looks good and it's working well ✅
|
Thanks for the quick review! 🙇 |
|
You guys were too quick for me, but thanks for the PR! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the issue raised in #44600 (comment) where existing classnames are accidentally included in
__unstableLayoutClassnamesresulting in the existing classnames being output twice.Why?
We used to output classnames to the outerwrapper so bundling
props?.classNamewas the right thing to do. Now that the layout classnames are passed to a different param, they should not includeprops?.className.How?
Remove
props?.classNamefrom the classnames that are passed to__unstableLayoutClassnames.Testing Instructions
As raised by @ndiego, following the instructions in the docs, we can add a custom classname to the
BlockListBlock. Here is some example code that you can copy + paste to the bottom ofpackages/block-editor/src/hooks/layout.jsto test out this problem:my-custom-class-block-classname, or if you opt the Cover block into__experimentalLayoutyou should also see this classname applied to the inner blocks wrapper where it shouldn't be.Screenshots or screencast
In the editor: