Data: Add ability to subscribe to one store, remove __unstableSubscribeStore #45513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: -7 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Awesome, thanks a lot @jsnajdr 👍 . Code looks good to me but I will let someone with more knowledge of this codebase review. |
kevin940726
approved these changes
Nov 7, 2022
packages/data/src/registry.js
Outdated
Comment on lines
51
to
53
| return isObject( storeNameOrDescriptor ) | ||
| ? storeNameOrDescriptor.name | ||
| : storeNameOrDescriptor; |
There was a problem hiding this comment.
Nit and probably unrelated to this PR, feel free to ignore.
Maybe it'd be easier to type to check for string instead?
Suggested change
| return isObject( storeNameOrDescriptor ) | |
| ? storeNameOrDescriptor.name | |
| : storeNameOrDescriptor; | |
| return typeof storeNameOrDescriptor === 'string' | |
| ? storeNameOrDescriptor | |
| : storeNameOrDescriptor.name; |
There was a problem hiding this comment.
Sounds like a good idea, implemented it 👍 One way it could backfire is when someone passes null and then the .name property access will crash. Previously we'd just use the null as a key into the stores map and simply find nothing. Hope nobody really does this.
jsnajdr
force-pushed
the
add/subscribe-one-store
branch
from
3d28d01 to
bf86777
Compare
jsnajdr
force-pushed
the
add/subscribe-one-store
branch
from
bf86777 to
d82b371
Compare
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
WordPress#45513) * Add ability to subscribe to one store, remove __unstableSubscribeStore * Check typeof string in getStoreName()
ryanwelcher
added
the
[Type] Code Quality
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #45481, this PR is adding support for subscribing to just one store with
registry.subscribe, via an optional second parameter.Now we can remove the
__unstableSubscribeStoremethod thatuseSelectused.useSelectnow uses only one remaining unstable internal API,__unstableMarkListeningStores.FYI @alexflorisca who requested this 🙂