Navigation: Removes the header from the navigation list view in the experiment #46070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: -129 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
getdave
reviewed
Nov 28, 2022
Comment on lines
-50
to
-55
| <Heading | ||
| className="wp-block-navigation-off-canvas-editor__title" | ||
| level={ 2 } | ||
| > | ||
| { __( 'Menu' ) } | ||
| </Heading> |
There was a problem hiding this comment.
I'm not sure we should remove this from the DOM. Is it accessible?
There was a problem hiding this comment.
Try using Voiceover and see what is announced as you tab into the panel. If it's nothing then we need to retain a heading. If we want to lose that visually we can utilise <VisuallyHidden>.
There was a problem hiding this comment.
I added a VisuallyHidden header that says Menu, but when I tested with VoiceOver I didn't hear it. Not sure what's going on...
|
This is working as intended, my only concern is the same as Dave's |
getdave
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Ok I've tested this. Weirdly Voiceover doesn't announce the heading. I think that's because its not focusable.
But...that's the same issue we have with the other tabs where panel headings such as Color are not read out either!
I think it's a wider issue. At least we've retained an accessible title.
As an aside, I think we'll need to find a better title other than "List View". It's not very descriptive of the contents of the tab. Maybe "Entity View"? That's for another PR though.
getdave
force-pushed
the
update/navigation-list-view-header
branch
from
b75e993 to
bcda4c6
Compare
scruffian
force-pushed
the
update/navigation-list-view-header
branch
from
bcda4c6 to
ae2e961
Compare
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…xperiment (WordPress#46070) * Navigation: Removes the header from the navigation list view * Add a visually hidden menu header for accessiblity
|
I somehow managed to miss this, but I think we need to revert this PR. As the goal of our experiment is to test the initial assumptions of the experiment, looking to see if users can find menu changing options in less proeminent controls was one of the goalposts. The original idea to move the menu selector in a dotted menu was to make a situation that is somewhat not common (multiple menus) less invasive in the UI. The heading should be removed when we can configure the inspector's top part to show the dot menu, but until then it's the best we've got. |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the Navigation List View experiment, we don't need to have a heading above the list view, and therefore hide the navigation menu selector - we can just display the selector directly.
Why?
This exposes these controls more readily, as suggested by @mtias.
How?
Removes a lot of the branching for the experiment, and makes the code a lot simpler too.
Testing Instructions
There are a few different cases to consider:
Consider what happens when the off canvas editing experiment is enabled and disabled
Consider what happens when the block inspector tabs experiment is enabled and disabled
Screenshots or screencast