Block editor: rich text: return early if __experimentalUndo is not defined #46152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Pretty straightforward, so merging after tests pass. |
DaisyOlsen
added
[Type] Bug
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & why?
It looks like some editor implementations (P2) are not passing an __experimentalUndo function in block settings, which causes an error when pressing Backspace/Delete/Escape after an automatic change such as the list and quote input rules.
We should return early when this is not defined to prevent the error and fall back to default behaviour.
How?
Testing Instructions
Screenshots or screencast