Page List: Render the children correctly in the editor #46165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrei Draganescu <107534+draganescu@users.noreply.github.com>
scruffian
added
[Type] Bug
|
Size Change: +75 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ajlende
reviewed
Nov 29, 2022
|
@talldan @youknowriad @Mamaduka pinging you in the context of you all having been involved in Mark applying block templates not persistent ( #45843 ): it seems we hit another problem with the way templates have been built to work. But this time it's not fixable, it's more of a question about what we want to do with block templates: it this a feature that should allow on the fly editing and applying via attribute and state changes, or is is something that is supposed to be synced once and then forgotten about? The question comes in the context of Pages List block implementing both inner blocks and the ability to filter the inner blocks via an attribute. We added inner blocks by making a block template b/c these inner blocks are not something editable, but automattic. But when we filter the blocks and reapply the template
Or is " |
|
@draganescu templates work hand in hand with "locking". If you want the template to keep being applied, I believe the locking should be "all" or something like that. |
ajlende
approved these changes
Nov 30, 2022
|
Does it still make sense to keep the changes introduced in #45843? |
1 task
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Page List: Render the children correctly in the editor Co-authored-by: Andrei Draganescu <107534+draganescu@users.noreply.github.com> * fix some leftovers from reimplementation (correcy deps and add memoization) Co-authored-by: Andrei Draganescu <107534+draganescu@users.noreply.github.com> Co-authored-by: Andrei Draganescu <andrei.draganescu@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Andrei Draganescu 107534+draganescu@users.noreply.github.com
What?
Alternative to #46122
This PR fixes a bug that appeared when merging #45861 and #45776 into trunk.
This has revealed that setting a template on inner blocks is not the right approach here. Instead we should use replaceBlocks, so avoid issues with template syncing.
Why?
To fix a bug where parent page selection is not reflected in the editor, but takes effect when the page list block is rendered.
Changes the implementation of the feature as well because fixing the bug in #46122 showed a problem with
synchronizeBlocksWithTemplatewhere we always do synchronisation, but in this case we need to replace the blocks when the parent page attribute changes, irrespective of what the page list block already contains.This implementation while less elegant impacts less things than altering how
synchronizeBlocksWithTemplateworks.How?
Replaces the approach where we pass a template to inner blocks, and instead use createBlock and replaceBlock.
Testing instructions