[RNMobile] Prevent error message from unneccesarily firing when uploading to Gallery block #46175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing 'isValidFileType' function doesn't always return true when it should for native images. This is because of a difference in the way data is retrieved for images on native. This commit updates the function to account for that difference.
|
Size Change: +1.55 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
SiobhyB
added
the
[Block] Gallery
SiobhyB
changed the title
|
@geriux, would you be able to help review this? You'll see I worked around the error by changing the way the |
SiobhyB
added
Mobile App - i.e. Android or iOS
Sure! I'll review it now 👍 |
geriux
reviewed
Nov 30, 2022
geriux
approved these changes
Nov 30, 2022
|
As a side note, it would be amazing if we could cover this case via a unit test, especially to avoid potential regressions in the future, wdyt? In general, I'd advocate introducing a test case in unit tests every time we spot and fix a bug. This way we ensure that the same problem won't happen again in the future 😅 . |
SiobhyB
pushed a commit
that referenced
this pull request
Nov 30, 2022
…ding to Gallery block (#46175) This PR ensures that any valid image uploaded to the Gallery block within the mobile apps is correctly marked as valid.
4 tasks
derekblank
added a commit
that referenced
this pull request
Dec 1, 2022
* Release script: Update react-native-editor version to 1.85.0 * Release script: Update with changes from 'npm run core preios' * Add user-facing changes to CHANGELOG * Update CHANGELOG * Release script: Update react-native-editor version to 1.85.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Prevent error message from unneccesarily firing when uploading to Gallery block (#46175) This PR ensures that any valid image uploaded to the Gallery block within the mobile apps is correctly marked as valid. * Update CHANGELOG Co-authored-by: Derek Blank <derekpblank@gmail.com>
SiobhyB
added
[Type] Bug
Thanks for the note @fluiddot, I'll look into adding a unit test for this next week. |
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…ding to Gallery block (WordPress#46175) This PR ensures that any valid image uploaded to the Gallery block within the mobile apps is correctly marked as valid.
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
* Release script: Update react-native-editor version to 1.85.0 * Release script: Update with changes from 'npm run core preios' * Add user-facing changes to CHANGELOG * Update CHANGELOG * Release script: Update react-native-editor version to 1.85.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Prevent error message from unneccesarily firing when uploading to Gallery block (WordPress#46175) This PR ensures that any valid image uploaded to the Gallery block within the mobile apps is correctly marked as valid. * Update CHANGELOG Co-authored-by: Derek Blank <derekpblank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures that any valid image uploaded to the Gallery block within the mobile apps is correctly marked as valid.
Why?
Following the updates to the Gallery block's error notices in #43946, the following error began displaying when uploading images to an existing Gallery block:
If uploading to a gallery all files need to be image formatsNote, the previous implementation of the error notices had not been supported on mobile. The referenced PR exposed a previously 'silent' issue by introducing an error notice that worked within the apps.
How?
The error began firing as the
isValidFileTypefunction was returningfalsefor existing images in a Gallery block on native:gutenberg/packages/block-library/src/gallery/edit.js
Lines 219 to 225 in f1dd9e1
The above function works for newly uploaded images, as those images return a
fileobject similar to the following:However, on native, images that are already uploaded to a Gallery block return a
fileobject similar to the following:To account for the different data that's retrieved for already-uploaded images on native, the
isValidFileTypefunction has been updated to gather themedia_typedetails from the file's raw image data:gutenberg/packages/block-library/src/gallery/edit.js
Lines 219 to 235 in 54decbe
Testing Instructions
If uploading to a gallery all files need to be image formatsdoesn't fire unexpectedly after uploading valid images.Screenshots or screencast
From these screenshots taken immediately after uploading an image to the gallery, you'll see that the first screenshot shows an error message despite the fact a valid image had been uploaded: