Page List Block: Fix error loading page list parent options #46327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
draganescu
added
[Type] Bug
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Co-authored-by: Andrei Draganescu <github@andreidraganescu.info>
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes a bug which crashes the page list block. Sometimes loading the pages is slower than we render the parent selector and this combobox crashes because it receives undefined as options, taking the block with it.
Why?
Bug fix.
How?
useParentOptionswhich is likely a leftover from all the recent updates of the page list blockTesting Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A