Navigation: Add a 'open list view' button #46335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
draganescu,
getdave,
SaxonF,
jasmussen,
MaggieCabrera and
ajlende
1 task
|
Size Change: +198 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
talldan
reviewed
Dec 7, 2022
|
Thanks for including a video. This is a replacement for the "Edit" button, right? It makes sense to me, and the icon plus tab connective tissue is valuable. Seems like it could work, and would love @SaxonF to also see this. |
scruffian
commented
Dec 7, 2022
packages/edit-post/src/plugins/navigation-list-view-menu-item.js
Outdated
Show resolved
Hide resolved
|
Thanks for the ping @jasmussen . I don't feel too strongly about this though just including an "Edit menu" label might be clearer, at least to start with until the navigation block is more widely adopted?
|
|
Since it's presumably easy to swap between the two, and I know these are seeing some testing by @annezazu, it seems we can pick one and then swap out if need be. In that light, I'd personally start with less (i.e. the icon), but not a strong opinion, and happy to refer to one. |
getdave
force-pushed
the
update/show-list-view-button
branch
from
af50294 to
ad269d1
Compare
getdave
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
This works as described.
Not your fault, but I find it disconcerting that we have code for adding stuff to the Nav block which has to live directly inside
- Site Editor
- Post Editor
It really should be possible to add the code within the block's directory itself and then register it to those locations.
It is possible, that was the way I did it at first, but then we tie the block to the edit-post and edit-site packages! |
scruffian
force-pushed
the
update/show-list-view-button
branch
from
ad269d1 to
1f6c135
Compare
scruffian
force-pushed
the
update/show-list-view-button
branch
2 times, most recently
from
2ab7fde to
a804064
Compare
|
In the edit-post plugin, the component prevents the LinkUI from showing, which I don't understand, but removing it seems to fix the tests :/ |
scruffian
force-pushed
the
update/show-list-view-button
branch
from
4b2af15 to
e059227
Compare
Is this still a problem? You merged so I guess not? |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a replacement for #45853.
This updates the list view button on the navigation block in the site editor to open the inspector controls, and also adds a new button to the navigation block in the post editor to open the inspector controls.
Why?
This is a bit controversial - on the one hand we shouldn't need a button to simply open the inspector controls. On the other hand, if users have the navigation block selected but they don't have the inspector controls open, this could be a useful prompt to open them.
How?
Adds a plugin to the edit-post package and updates the current list view button in edit-site.
Testing Instructions
5. Click the button and confirm it opens the inspector controls for the Navigation block:
6. Do the same test in the site editorTesting Instructions for Keyboard
Screenshots or screencast
Dec-06-2022.17-01-10.mp4