MaybeCategoryPanel: Avoid 403 requests for users with low permissions #46349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +25 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Should we add |
|
@ntsekouras, I thought about that, but I'm sure if The root index is supposed to include a small amount of data about the site. However, without more granular control over site settings, we'll end up duplicating everything in the site index. |
ntsekouras
approved these changes
Dec 7, 2022
|
Thanks for voicing an important question and the review, Nik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes failing 403 requests in the
MaybeCategoryPanelcomponent for low permission roles like Contributor and Author.Why?
Currently, the panel isn't displayed for Contributor and Author roles. This is because these roles don't have permission to read the site settings, but requests are still made, failing with a 403 error code.
See #42612.
Testing Instructions
Testing Instructions for Keyboard
No UI changes.