Navigation Block: Update attribute test for are-blocks-dirty.js
#46355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
getdave
approved these changes
Dec 7, 2022
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
ryanwelcher
changed the title
are-blocks-dirty.jsare-blocks-dirty.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the "should be dirty if the blocks' attributes don't match" unit test for the
are-blocks-dirty.jsfile.Why?
This update ensures that this file has 100% test coverage, as we were only missing coverage for line 44.
How?
Adds more attributes to the mock objects so we can compare the attributes in the first array to the second.
Testing Instructions
Run the following command to check coverage and ensure tests are passing:
npm run test:unit are-blocks-dirty.js -- --coverageWith this PR, this file should have 100% coverage.
Testing Instructions for Keyboard
Screenshots or screencast