Update: Use offsite navigation editor on the navigation inspector sidebar. #46440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +41 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
use/offsite-menu-component-on-the-navigation-inspector
branch
2 times, most recently
from
a373c93 to
a1900ac
Compare
|
This looks like a good start. I noticed quite a few things don't work:
|
Hi @scruffian, the inserter edit, etc, are hidden without the experiment enabled. I guess we can merge as these features are hidden without the experiment and then look into fixing these issues in the OffCanvasEditor component? |
That's true, but if we're going down this route we should probably put the behind the same experimental flag, so it only shows up when people opt in. |
|
|
There are other things that the Off Canvas Editor experiment enables though for example "Add a submenu item" I just wonder if its safer to just default to the old view until you enable the experiment... |
getdave
requested changes
Dec 14, 2022
There was a problem hiding this comment.
With respect, I really think we should have everything related to the offcanvas editor behind the experiment flag.
Why?
The engineering decisions behind that offcanvas have been taken to prioritise expediency to allow for early testing and UX feedback. As a result it is not suitable for exposure outside of the experiment.
Doing that at this time could hinder progress on the offcanvas experiment as bugs would need to be fixed and trunk more closely monitored for breakages. At this time we're still waiting on feedback from the community as to whether offcanvas is a good experience.
If that makes the Navigation element of the Navigation panel redundant then it should be removed for now or again be placed behind the experiment flag.
jorgefilipecosta
force-pushed
the
use/offsite-menu-component-on-the-navigation-inspector
branch
from
a1900ac to
a1534b9
Compare
jorgefilipecosta
force-pushed
the
use/offsite-menu-component-on-the-navigation-inspector
branch
from
a1534b9 to
81f1947
Compare
Hi @getdave, thank you for sharing your thoughts. I updated this PR to use the new component if the flag is enabled. On the browse sidebar, we will also only show the navigation menu item if the experiment is enabled. I think this addresses your concerns. |
youknowriad
approved these changes
Dec 16, 2022
jorgefilipecosta
deleted the
use/offsite-menu-component-on-the-navigation-inspector
branch
|
@jorgefilipecosta Thank you for being so considerate and apologies for blocking with that review 🙇 |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the navigation inspector sidebar to use the new navigation offsite editor being worked on:
https://github.com/orgs/WordPress/projects/60/views/1
If the navigation offsite editor is disabled, the edit button and the appended are not shown, so it behaves similarly to what we have now.
This change also allows browse mode navigation menus to take advantage of the new menu editor. After this PR, and #46436 are merged.
cc: @scruffian
Screenshots or screencast
Off-canvas editor enable:
Off-canvas editor disable:
