Site Editor: Don't show block inserter when the canvas is view mode #46763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Feature] Inserter
|
Size Change: +15 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Dec 23, 2022
12 tasks
youknowriad
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46720
What?
This PR hides the block inserter when the site editor canvas is in view mode.
Why?
When the canvas is in view mode, there is no operation on the block editor, so pressing the + button does not respond. This button should be expected not to be displayed when in view mode.
How?
Added a display condition for the
renderAppenderprop of<BlockList />, whether it is in view mode or not.Testing Instructions
In both the Template Editor and the Template Parts Editor, check the following:
Screenshots or screencast
Before
before.mp4
After
after.mp4