-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile - Move the gutenberg-editor-block-insertion-2
E2E tests to integration tests
#46882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts into integration tests
geriux
added
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Mobile App - Automation
Label used to initiate Mobile App PR Automation
labels
Jan 4, 2023
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
SiobhyB
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The tests pass as expected and the logic makes sense to me. Thank you @geriux 🎉 🙇♀️
geriux
removed
the
Mobile App - Automation
Label used to initiate Mobile App PR Automation
label
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
gutenberg-editor-block-insertion-2
E2E tests to integration tests wordpress-mobile/gutenberg-mobile#5369Follow up of #46822
What?
This PR removes the
gutenberg-editor-block-insertion-2
E2E tests in favor of moving them to integration tests.Why?
These tests didn't test anything native related so we continued the effort of #46822 and it migrates the rest. This reduces the time E2E tests take to run as well.
How?
By moving the E2E tests into integration tests.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A