Navigation: Add a manage menus button to the menu selector dropdown #47005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +47 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 859ca69. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3882671159
|
getdave
reviewed
Jan 11, 2023
Does it need to be? Manage menus is an action that can happen at any point I think. |
Actually no. Only the "Create Menus". |
getdave
approved these changes
Jan 12, 2023
|
Followup here: #47115 |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The adds the "manage menus" button to the navigation menu selector component when the offcanvas editor is enabled.
Why?
We should give users a way to manage their menus.
How?
This requires a slight change to the ManageMenusButton component, to switch it to use a MenuItem rather than a Button.
Testing Instructions
Testing Instructions for Keyboard
As above.
Screenshots or screencast