Block inserter search e2e test: scope list item lookup to the inserter panel #47066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
approved these changes
Jan 11, 2023
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in faea1dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3893347308
|
mburridge
added
General Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45332. There is a flaky e2e test, "passes the search value in the main inserter when clicking
Browse all":Most recently seen in @tyxla's #47056 (comment) and also in #46467 (enabling concurrent mode) where I originally fixed it.
There's a situation that looks like this:
We enter a search term into a popover block inserter ("Verse"), then click "Browse all" and expect the search term to be transferred to the sidebar inserter panel.
But there is a brief moment in time where both inserters are shown. The panel is displayed synchronously after clicking on "Browse all", but the popover is hidden only a bit later, after a
setTimeout( fn, 0 )insideuseFocusOutside.Sometimes the test catches just that moment and then finds two block list items instead of just one. I'm fixing the test by scoping the list item lookup only to the sidebar panel.