Update the site hub to show the page title and the template title #47140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
My personal feeling is that it's:
That said, I'm happy to disagree and commit. |
|
Size Change: +78 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Thank you for putting this together, it's working as advertised:
It's true, this is a forward thinking change based on the idea that the general site editing experience will be more "content first" when we add other features like browse-aility. Still, if we delay the change then we risk frustrating folks by changing the behaviour of a fairly critical element in the UX down the road.
Do you mean whether it's a template or a template part? I'm not too worried about that because (imo) the frame contents makes it clear enough, e.g:
Though it's worth noting the frame height should wrap the template part height. I'm sure we had that before, so perhaps this was a regression from another change 🤔 The only thing I'm not sure about is whether or not to display the site title when there's no item of reference:
Keen to get the thoughts of @WordPress/gutenberg-design here. |
I think so yes. |
I still don't consider this a blocker personally, but I explored it a bit more anyway. None of these designs feel right, but sharing in case they inspire: Text label
This feels too noisy, and we'd run into issues with long titles / localisation Icons
I'm not keen on the small icons which break the existing sizing convention, but I already had to increase the general dimensions to make this work visually so would consider this a maximum. Also not entirely sure the icons are intuitive enough... they're ok for delineating templates from template parts, but posts from pages? This approach could also get tricky with duplicate taxonomy names for different post types, and custom post types in general. Tooltips
I suppose this could be a low-risk short-term solution. But it might interfere with interactions we want to add to the site hub in the future (e.g. Invoking a global search, viewing the frontend, etc). As I said, none of these feel right. Imo we can merge this, and address this detail in a follow-up if/when the need arises. |
|
Ok how should we proceed here? Merge? Add the site title when there's no "content"? |
|
I'd avoid icons for the time being. I also tend to lean towards #47140 (comment) that we might want to pause this PR until we're a bit further with the role of the site hub. Something like figuring out where the global save button exists, that seems a tough nut to crack on its own, and might inform what we show as far as titles. Not a strong opinion. |
|
Closing this as the design has evolved already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #36667
What?
This PR updates the site hub to show the "page title" and "template title" instead of the "template title" and "template type" per suggestion from @jameskoster
Testing Instructions
1- Open the site editor
2- Navigate it and check how the content of the site hub changes.