Update the site editor for better initialization #47182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clarify what to look for? I'm not entirely sure what to look for. This is what I see:
That looks good enough though, except for the navigation spinner, which is a separate issue: @getdave do you know if the big page list spinner is on your group's radar? Happy to open an issue if that's useful. |
|
Size Change: +108 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Basically this PR impacts all what happens before the content of the template is loaded. In trunk there's a white page followed by a gray page followed by the content being filled. In this PR the first two steps are with a white page + spinner and a simple white page, which makes less noise when you reload. |
jasmussen
approved these changes
Jan 16, 2023
tyxla
approved these changes
Jan 16, 2023
youknowriad
added
the
[Feature] Site Editor
|
Flaky tests detected in 59f11c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3930218957
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #35503
What?
This PR polishes the loading state of the site editor a little bit. It doesn't solve the issue entirely (because we'll need Suspense for the different blocks loaders) but it introduces these two elements:
Testing Instructions
1- Open the site editor
2- Refresh the page
Compare to trunk and you may also throttle the network speed to experience the changes better.