-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Link Control action button visuals #47306
Merged
getdave
merged 1 commit into
trunk
from
update/link-control-buttons-to-avoid-button-group
Jan 20, 2023
Merged
Fix Link Control action button visuals #47306
getdave
merged 1 commit into
trunk
from
update/link-control-buttons-to-avoid-button-group
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
label
Jan 20, 2023
Size Change: -3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
richtabor
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
10 tasks
juanmaguitar
added
the
[Type] Bug
An existing feature does not function as intended
label
Feb 1, 2023
ntsekouras
pushed a commit
that referenced
this pull request
Feb 23, 2023
This reverts commit 2499646.
ntsekouras
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Revert "Move Link Control action buttons into lower area (#47309)" This reverts commit e605937. * Revert "Fix Link Control action button visuals (#47306)" This reverts commit 2499646. * Revert "Add clear Apply and Cancel buttons to Link Control (#46933)" This reverts commit 875628f. # Conflicts: # packages/block-editor/src/components/link-control/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Link Editing
Link components (LinkControl, URLInput) and integrations (RichText link formatting)
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses feedback in #46933 (comment)
Why?
Resolve visual glitches.
How?
Remove
<ButtonGroup>
.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast