Remove double edit button in LinkUI #47454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
|
Size Change: -324 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ndiego
approved these changes
Jan 26, 2023
|
Thanks @draganescu 👍 |
draganescu
force-pushed
the
try/remove-double-link-ui-button
branch
from
43a5e1a to
d58f79e
Compare
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47413
What?
In #20366 a button to navigate to the link inside the site editor was added. In the mean time LinkUI got its own edit button
to edit the set link for inline links. The two buttons now collide.
Why?
Because there are two buttons that look the same and do differnt things.
How?
I left the infrastructure built by #20366 - e.g. a slot in LinkUI button area - for a future where we may want this back.
Only removed the button addition in the block editor component in the site editor.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast