Global styles: Reselect blocks after pasting styles #47590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional tools panel items are selected
glendaviesnz
added
the
Global Styles
|
Size Change: +22 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
richtabor
approved these changes
Feb 1, 2023
glendaviesnz
added
the
Backport to WP 6.7 Beta/RC
|
This fix doesn't seem to work consistently when I test it, and I also noticed there are similar issues with the design tools not appearing or hiding when using undo/redo: Kapture.2023-02-02.at.10.48.40.mp4I might be good to investigate whether the tools panel can be made reactive to the addition/removal of styles. |
|
Hmm, it works every time for me on the PR branch still, but hardly at all in trunk, so something has been added to trunk which has made it fragile, so I will take a look at a more robust solution. |
|
Thanks Glen! |
Mamaduka
added
the
Backport to Gutenberg RC
Mamaduka
pushed a commit
that referenced
this pull request
Feb 3, 2023
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: fc85b3e |
Mamaduka
removed
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reselect blocks on which styles were pasted.
Why?
In order to ensure that any optional tools panels controls are reloaded to show any related styles that have just been pasted.
Fixes: #47368
How?
First removes the block selection and then reselects the relevant blocks.
Testing Instructions
Copy stylesoption from the block actions menuPaste stylesoption from the block actions menuScreenshots or screencast
Before:
paste-styles-before.mp4
After:
paste-styles-after.mp4