Page List: Respect the selected parent page when converting to a list of navigation links #47651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +88 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d669a97. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4115677675
|
draganescu
reviewed
Feb 7, 2023
| @@ -30,11 +37,57 @@ export function convertToNavigationLinks( pages = [] ) { | |||
| // Use a placeholder if the child appears before parent in list. | |||
| linkMap[ parent ] = { innerBlocks: [] }; | |||
| } | |||
| // Although these variables are not referenced, they are needed to store the innerBlocks in memory. | |||
There was a problem hiding this comment.
I don't understand: how are they useful if nobody reads them?
There was a problem hiding this comment.
I don't 100% get it either. I think it means they are stored in memory, so that they don't get lost when a mutation happens. This is old code that might be possible to write in a clearer way, but I think that's outside of the scope of this PR.
There was a problem hiding this comment.
If you remove these lines it breaks :)
draganescu
reviewed
Feb 7, 2023
| * | ||
| * @return {Object} The navigation link block with the given id. | ||
| */ | ||
| function findById( navigationLinks, id ) { |
There was a problem hiding this comment.
Since it's not generic the name should reflect that findNavigationLinkById
draganescu
reviewed
Feb 7, 2023
packages/block-library/src/page-list/use-convert-to-navigation-links.js
Outdated
Show resolved
Hide resolved
draganescu
reviewed
Feb 7, 2023
| let navigationLinks = createNavigationLinks( pages ); | ||
|
|
||
| // If a parent page ID is provided, only return the children of that page. | ||
| if ( parentPageID ) { |
There was a problem hiding this comment.
Nit: I wonder if we should not instead filter pages and use createNavigationLinks on the filtered pages?
There was a problem hiding this comment.
I thought about that, but it's technically more complex as pages isn't a nested array, so we'd have to filter on a parent id, and then all the parents of that id, and then all the parents of that one etc. I think this approach is simpler.
draganescu
approved these changes
Feb 7, 2023
DaisyOlsen
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When converting a Page List block to a list of links we should respect the selected parent, rather than using all pages.
Why?
This is the expected behaviour.
How?
We need to do some quite complex recursion over the innerBlocks to ensure that we find the right block to use as a parent. The
findByIdfunction could be made more general.Testing Instructions
Testing Instructions for Keyboard
As above
Screenshots or screencast
Screen.Recording.2023-02-01.at.15.42.01.mov