Page List: Invoke the convert to links modal on any interactions with the page list item block #47748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
scruffian
commented
Feb 3, 2023
| event | ||
| ); | ||
| } | ||
| if ( blockSelectionResult !== false ) { |
There was a problem hiding this comment.
This is needed to allow blocks to prevent their selection.
scruffian
commented
Feb 3, 2023
packages/block-library/src/navigation/edit/menu-inspector-controls.js
Outdated
Show resolved
Hide resolved
scruffian
commented
Feb 3, 2023
| 'This menu is automatically kept in sync with pages on your site. You can manage the menu yourself by clicking "Edit" below.' | ||
| ); | ||
|
|
||
| export function ConvertToLinksModal( { onClick, disabled, closeModal } ) { |
There was a problem hiding this comment.
I had to convert this into a controlled component so it could be invoked from other places.
scruffian
commented
Feb 3, 2023
| @@ -242,6 +202,10 @@ export default function PageListEdit( { | |||
| title: page.title?.rendered, | |||
| link: page.url, | |||
| hasChildren, | |||
| onSelect: () => { | |||
| openModal(); | |||
| return false; | |||
There was a problem hiding this comment.
returning false stops the block being selected in the canvas.
|
Size Change: +79 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
I don't really like that the modal opens up on click. To me it seems like clicking should select the page list block instead where you then have the option to edit it. That seems to match the experience of the in-canvas editor right now. |
|
We shouldn't need to edit off canvas and the navigation block, in my head, it should be something that only page list knows about. That means:
|
The changes in these components are simply to pass control of how interactions are handled to the block itself. Other blocks could handle this in different ways depending on what behaviour they wanted. |
|
But it shouldn't be a general thing, right? It's a feature of the page list that it's locked but not really only when in navigation. Sounds so specific to me, I can't think of other blocks that would have this weird behavior. |
|
I broke the refactoring part into another PR: #47922 |
|
Taking this one for a spin, but I may be doing something wrong as I'm not able to reproduce the modal:
On a separate note, Can we visually hide the Page List "container" block? I.e. instead of: We have just: ? |
10 tasks
|
This is the wrong interaction model. We should close it and do it a different way (with a useEffect in Page List Item). |
|
Close in favor of #48723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When users interact with the Page List Items in the Navigation List View, we should invoke the "convert to links" modal, to make it clear that these items can't be edited.
Questions
cc @SaxonF @richtabor
Fixes #47064
Why?
To make it clear that these items can't be edited, and allow users to do so.
How?
This allows blocks to create their own
onSelectattribute which is a function which is called when the block is selected in the OffCanvasEditor.Testing Instructions
Testing Instructions for Keyboard
As above.
Screenshots or screencast
Screen.Recording.2023-02-03.at.18.51.06.mov