-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Data: Fix ESLint warnings for the hooks directory #47811
Conversation
Flaky tests detected in 3b25b6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4111109144
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix.
Would it be a good idea to promote this warning to an error? People fix those warnings anyway, so why not enforce that on PR authors?
That makes sense and will match PHPCS standards. You'll have to commit extra changes when working in the files with warnings. I think most of us have "format on save" enabled in the editors. We can fix the remaining warning in a single go and add the commit to the |
I think it requires running |
The ESLint extensions does, at least in VSCode. |
What?
PR fixes ESLint warning for Code Data hooks.
Why?
Ideally, the project should not have any ESLint errors and warnings.
How?
Testing Instructions
Running following lint command should return warnings
Screenshots or screencast