[RNMobile] Enable new block in Gutenberg Mobile #47836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
changed the title
2 tasks
|
Flaky tests detected in 33864d0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4125839606
|
As per this issue, Hermes doesn't currently support named capturing groups: facebook/hermes#696 This commit addresses that by using the 'plugin-transform-named-capturing-groups-regex' plugin.
|
Size Change: +614 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
3 tasks
SiobhyB
commented
Feb 8, 2023
| @@ -13,6 +13,7 @@ module.exports = function ( api ) { | |||
| '../../node_modules/@babel/plugin-proposal-async-generator-functions' | |||
| ), | |||
| '@babel/plugin-transform-runtime', | |||
| '@babel/plugin-transform-named-capturing-groups-regex', | |||
There was a problem hiding this comment.
The new block makes use of regex named capture groups, which is only supported in the version of Hermes available in RN 0.71 (see facebook/hermes#696 for more details). This resulted in the following error:
bundle/android/App.text.js:3647:961: error: Invalid regular expression: Quantifier has nothing to repeat
...atch(/^https?:\/\/(?<host>video(?:\.word|s\.files\.word)?press\.com)(?:\/v|\/embed)?\/(?<guid>[a-zA-Z\d]{8})/);ret...
The use of @babel/plugin-transform-named-capturing-groups-regex is a workaround to that error.
There was a problem hiding this comment.
Good catch! I was wondering if we'd need to add this package as a dependency but noticed in the documentation that is already included when using @babel/preset-env, which is a dependency in Gutenberg (reference).
4 tasks
SiobhyB
added
the
Mobile App - i.e. Android or iOS
3 tasks
fluiddot
approved these changes
Feb 9, 2023
| @@ -13,6 +13,7 @@ module.exports = function ( api ) { | |||
| '../../node_modules/@babel/plugin-proposal-async-generator-functions' | |||
| ), | |||
| '@babel/plugin-transform-runtime', | |||
| '@babel/plugin-transform-named-capturing-groups-regex', | |||
There was a problem hiding this comment.
Good catch! I was wondering if we'd need to add this package as a dependency but noticed in the documentation that is already included when using @babel/preset-env, which is a dependency in Gutenberg (reference).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new block to the Gutenberg editor.
Why?
It's currently necessary to register all new blocks via the Gutenberg repository, but there is an open issue at wordpress-mobile/gutenberg-mobile#3911 for changing this in the future.
How?
The pattern for registering previous blocks has been followed.
Testing Instructions
Please refer to wordpress-mobile/gutenberg-mobile#5459 for specific testing steps and more information related to the block.